-
-
Notifications
You must be signed in to change notification settings - Fork 29
Expand file tree
/
Copy pathClanServiceTest.java
More file actions
434 lines (357 loc) · 15.5 KB
/
ClanServiceTest.java
File metadata and controls
434 lines (357 loc) · 15.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
package com.faforever.api.clan;
import com.faforever.api.clan.result.InvitationResult;
import com.faforever.api.config.FafApiProperties;
import com.faforever.api.data.domain.Clan;
import com.faforever.api.data.domain.ClanMembership;
import com.faforever.api.data.domain.Player;
import com.faforever.api.error.ApiException;
import com.faforever.api.error.ErrorCode;
import com.faforever.api.error.ProgrammingError;
import com.faforever.api.player.PlayerRepository;
import com.faforever.api.player.PlayerService;
import com.faforever.api.security.JwtService;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.ExpectedException;
import org.junit.runner.RunWith;
import org.mockito.ArgumentCaptor;
import org.mockito.Mock;
import org.mockito.Mockito;
import org.mockito.junit.MockitoJUnitRunner;
import org.springframework.security.jwt.Jwt;
import java.io.IOException;
import java.util.Collections;
import java.util.Optional;
import static com.faforever.api.error.ApiExceptionMatcher.hasErrorCode;
import static org.hamcrest.Matchers.greaterThan;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.mockito.Matchers.any;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
public class ClanServiceTest {
@Rule
public ExpectedException expectedException = ExpectedException.none();
private ClanService instance;
@Mock
private ClanRepository clanRepository;
@Mock
private PlayerRepository playerRepository;
@Mock
private FafApiProperties fafApiProperties;
@Mock
private JwtService jwtService;
@Mock
private PlayerService playerService;
@Mock
private ClanMembershipRepository clanMembershipRepository;
@Before
public void setUp() throws Exception {
instance = new ClanService(clanRepository, playerRepository, fafApiProperties, jwtService, playerService, clanMembershipRepository, new ObjectMapper());
}
@Test
public void createClanWhereLeaderIsAlreadyInAClan() {
String clanName = "My cool Clan";
String tag = "123";
String description = "A cool clan for testing";
Player creator = new Player();
creator.setId(1);
creator.getClanMemberships().add(new ClanMembership());
try {
instance.create(clanName, tag, description, creator);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_CREATE_CREATOR_IS_IN_A_CLAN));
}
verify(clanRepository, Mockito.never()).save(any(Clan.class));
}
@Test
public void createClanWithSameName() {
String clanName = "My cool Clan";
String tag = "123";
String description = "A cool clan for testing";
Player creator = new Player();
creator.setId(1);
when(clanRepository.findOneByName(clanName)).thenReturn(Optional.of(new Clan()));
try {
instance.create(clanName, tag, description, creator);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_NAME_EXISTS));
}
ArgumentCaptor<Clan> clanCaptor = ArgumentCaptor.forClass(Clan.class);
verify(clanRepository, Mockito.times(0)).save(clanCaptor.capture());
}
@Test
public void createClanWithSameTag() {
String clanName = "My cool Clan";
String tag = "123";
String description = "A cool clan for testing";
Player creator = new Player();
creator.setId(1);
when(clanRepository.findOneByName(clanName)).thenReturn(Optional.empty());
when(clanRepository.findOneByTag(tag)).thenReturn(Optional.of(new Clan()));
try {
instance.create(clanName, tag, description, creator);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_TAG_EXISTS));
}
ArgumentCaptor<Clan> clanCaptor = ArgumentCaptor.forClass(Clan.class);
verify(clanRepository, Mockito.times(0)).save(clanCaptor.capture());
}
@Test
public void createClanSuccessful() {
String clanName = "My cool Clan";
String tag = "123";
String description = "A cool clan for testing";
Player creator = new Player();
creator.setId(1);
when(clanRepository.findOneByName(clanName)).thenReturn(Optional.empty());
when(clanRepository.findOneByTag(tag)).thenReturn(Optional.empty());
instance.create(clanName, tag, description, creator);
ArgumentCaptor<Clan> clanCaptor = ArgumentCaptor.forClass(Clan.class);
verify(clanRepository, Mockito.times(1)).save(clanCaptor.capture());
assertEquals(clanName, clanCaptor.getValue().getName());
assertEquals(tag, clanCaptor.getValue().getTag());
assertEquals(description, clanCaptor.getValue().getDescription());
assertEquals(creator, clanCaptor.getValue().getLeader());
assertEquals(creator, clanCaptor.getValue().getFounder());
assertEquals(1, clanCaptor.getValue().getMemberships().size());
assertEquals(creator, clanCaptor.getValue().getMemberships().get(0).getPlayer());
assertEquals(false, clanCaptor.getValue().getIsOpen());
}
@Test
public void generatePlayerInvitationTokenWithInvalidClan() throws IOException {
Player requester = new Player();
requester.setId(1);
try {
instance.generatePlayerInvitationToken(requester, 45, 42);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_NOT_EXISTS));
}
verify(jwtService, Mockito.never()).sign(any());
}
@Test
public void generatePlayerInvitationTokenFromNonLeader() throws IOException {
Player requester = new Player();
requester.setId(1);
Player newMember = new Player();
newMember.setId(2);
Player leader = new Player();
leader.setId(3);
Clan clan = ClanFactory.builder().leader(leader).build();
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
try {
instance.generatePlayerInvitationToken(requester, newMember.getId(), clan.getId());
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_NOT_LEADER));
}
verify(jwtService, Mockito.never()).sign(any());
}
@Test
public void generatePlayerInvitationTokenInvalidPlayer() throws IOException {
Player requester = new Player();
requester.setId(1);
Clan clan = ClanFactory.builder().leader(requester).build();
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
try {
instance.generatePlayerInvitationToken(requester, 42, clan.getId());
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_GENERATE_LINK_PLAYER_NOT_FOUND));
}
verify(jwtService, Mockito.never()).sign(any());
}
@Test
public void generatePlayerInvitationToken() throws IOException {
Player requester = new Player();
requester.setId(1);
Player newMember = new Player();
newMember.setId(2);
Clan clan = ClanFactory.builder().leader(requester).build();
FafApiProperties props = new FafApiProperties();
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
when(playerRepository.findById(newMember.getId())).thenReturn(Optional.of(newMember));
when(fafApiProperties.getClan()).thenReturn(props.getClan());
instance.generatePlayerInvitationToken(requester, newMember.getId(), clan.getId());
ArgumentCaptor<InvitationResult> captor = ArgumentCaptor.forClass(InvitationResult.class);
verify(jwtService, Mockito.times(1)).sign(captor.capture());
assertThat("expire",
captor.getValue().getExpire(),
greaterThan(System.currentTimeMillis()));
assertEquals(newMember.getId(), captor.getValue().getNewMember().getId());
assertEquals(newMember.getLogin(), captor.getValue().getNewMember().getLogin());
assertEquals(clan.getId(), captor.getValue().getClan().getId());
assertEquals(clan.getTag(), captor.getValue().getClan().getTag());
assertEquals(clan.getName(), captor.getValue().getClan().getName());
}
@Test
public void generatePlayerOpenInvitationToken() throws IOException {
Player requester = new Player();
requester.setId(1);
Clan clan = ClanFactory.builder().leader(requester).build().setIsOpen(false);
FafApiProperties props = new FafApiProperties();
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
when(fafApiProperties.getClan()).thenReturn(props.getClan());
instance.generatePlayerInvitationToken(requester, clan.getId());
// What do i do with this??
// Invitation result should be modified to accept null players but i have no IDE here so navigating is a pain
/*
ArgumentCaptor<InvitationResult> captor = ArgumentCaptor.forClass(InvitationResult.class);
verify(jwtService, Mockito.times(1)).sign(captor.capture());
assertEquals(captor.getValue().getExpire(), 0);
assertEquals(null, captor.getValue().getNewMember());
*/
assertEquals(clan.getId(), getValue().getClan().getId());
/*
assertEquals(clan.getTag(), captor.getValue().getClan().getTag());
assertEquals(clan.getName(), captor.getValue().getClan().getName());
*/
}
@Test
public void acceptPlayerInvitationTokenExpire() throws IOException {
String stringToken = "1234";
long expire = System.currentTimeMillis();
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s}", expire));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_ACCEPT_TOKEN_EXPIRE));
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerOpenInvitationCannotExpire() throws IOException {
// Why is the clan passed nowhere here?? How do I make it not expire if the clan is open since no clan is passed as part of the test?
String stringToken = "1234";
long expire = System.currentTimeMillis();
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s}", expire));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_ACCEPT_TOKEN_EXPIRE));
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerInvitationTokenInvalidClan() throws IOException {
String stringToken = "1234";
long expire = System.currentTimeMillis() + 1000 * 3;
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s,\"clan\":{\"id\":42}}", expire));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_NOT_EXISTS));
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerInvitationTokenInvalidPlayer() throws IOException {
String stringToken = "1234";
Clan clan = ClanFactory.builder().build();
long expire = System.currentTimeMillis() + 1000 * 3;
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s,\"newMember\":{\"id\":2},\"clan\":{\"id\":%s}}",
expire, clan.getId()));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ProgrammingError e) {
assertEquals("ClanMember does not exist: 2", e.getMessage());
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerInvitationTokenWrongPlayer() throws IOException {
String stringToken = "1234";
Player newMember = new Player();
newMember.setId(2);
Clan clan = ClanFactory.builder().build();
Player otherPlayer = new Player();
otherPlayer.setId(3);
long expire = System.currentTimeMillis() + 1000 * 3;
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s,\"newMember\":{\"id\":%s},\"clan\":{\"id\":%s}}",
expire, newMember.getId(), clan.getId()));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
when(playerRepository.findById(newMember.getId())).thenReturn(Optional.of(newMember));
when(playerService.getPlayer(any())).thenReturn(otherPlayer);
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_ACCEPT_WRONG_PLAYER));
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerInvitationTokenPlayerIAlreadyInAClan() throws IOException {
String stringToken = "1234";
Clan clan = ClanFactory.builder().build();
Player newMember = new Player();
newMember.setId(2);
newMember.setClanMemberships(
Collections.singleton(new ClanMembership().setClan(clan).setPlayer(newMember)));
long expire = System.currentTimeMillis() + 1000 * 3;
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s,\"newMember\":{\"id\":%s},\"clan\":{\"id\":%s}}",
expire, newMember.getId(), clan.getId()));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
when(playerRepository.findById(newMember.getId())).thenReturn(Optional.of(newMember));
when(playerService.getPlayer(any())).thenReturn(newMember);
try {
instance.acceptPlayerInvitationToken(stringToken, null);
fail();
} catch (ApiException e) {
assertThat(e, hasErrorCode(ErrorCode.CLAN_ACCEPT_PLAYER_IN_A_CLAN));
}
verify(clanMembershipRepository, Mockito.never()).save(any(ClanMembership.class));
}
@Test
public void acceptPlayerInvitationToken() throws IOException {
String stringToken = "1234";
Clan clan = ClanFactory.builder().build();
Player newMember = new Player();
newMember.setId(2);
long expire = System.currentTimeMillis() + 1000 * 3;
Jwt jwtToken = Mockito.mock(Jwt.class);
when(jwtToken.getClaims()).thenReturn(
String.format("{\"expire\":%s,\"newMember\":{\"id\":%s},\"clan\":{\"id\":%s}}",
expire, newMember.getId(), clan.getId()));
when(jwtService.decodeAndVerify(any())).thenReturn(jwtToken);
when(clanRepository.findById(clan.getId())).thenReturn(Optional.of(clan));
when(playerRepository.findById(newMember.getId())).thenReturn(Optional.of(newMember));
when(playerService.getPlayer(any())).thenReturn(newMember);
instance.acceptPlayerInvitationToken(stringToken, null);
ArgumentCaptor<ClanMembership> captor = ArgumentCaptor.forClass(ClanMembership.class);
verify(clanMembershipRepository, Mockito.times(1)).save(captor.capture());
assertEquals(newMember.getId(), captor.getValue().getPlayer().getId());
assertEquals(clan.getId(), captor.getValue().getClan().getId());
}
}