From a14d9ab9890ba72229cc59d36eef09c62609b891 Mon Sep 17 00:00:00 2001 From: Sanmesh Kakade Date: Wed, 15 Jul 2026 21:21:40 +0530 Subject: [PATCH 1/4] feat(aws_eks): expose facets_dedicated min_nodes in spec Add min_nodes to the facets_dedicated nodepool spec (default 1) so the dedicated managed node group's minimum size is configurable. Set >= 2 for HA of the platform components pinned to the dedicated node pool. Consumed by facets-iac aws_eks/0.2 via spec.nodepools.facets_dedicated.min_nodes. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../kubernetes_cluster/aws_eks/0.2/facets.yaml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml index a61bdf366..d2d696d1b 100644 --- a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml +++ b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml @@ -205,6 +205,19 @@ spec: field: spec.nodepools.facets_dedicated.enable values: [true] x-ui-overrides-only: true + min_nodes: + title: Min Nodes + description: Minimum number of worker nodes in the node pool. Set to + 2 or more for high availability of the platform components pinned to + this node pool. + type: integer + minimum: 1 + maximum: 200 + default: 1 + x-ui-visible-if: + field: spec.nodepools.facets_dedicated.enable + values: [true] + x-ui-overrides-only: true instance_type: title: Instance Type description: Instance type for Facets Dedicated Node Pool @@ -243,7 +256,7 @@ spec: values: [true] required: ["instance_type"] x-ui-order: [enable, instance_type, node_lifecycle_type, root_disk_volume, - max_nodes, ami_id, ami_name_filter, ami_owner_id] + max_nodes, min_nodes, ami_id, ami_name_filter, ami_owner_id] ondemand_fallback: title: Ondemand Fallback Nodepool Spec description: Specifications of Ondemand Fallback Nodepool From 024bbfd795deeab7a093e920c06c12cee28ec5a5 Mon Sep 17 00:00:00 2001 From: Sanmesh Kakade Date: Wed, 15 Jul 2026 21:33:26 +0530 Subject: [PATCH 2/4] feat(aws_eks): add facets_dedicated desired_nodes to spec Optional desired_nodes for the facets_dedicated nodepool. Falls back to min_nodes when unset. Applied at node pool creation only (managed node group ignores desired_size on updates); bounded to [min_nodes, max_nodes]. Co-Authored-By: Claude Opus 4.8 (1M context) --- modules/kubernetes_cluster/aws_eks/0.2/facets.yaml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml index d2d696d1b..2610cb779 100644 --- a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml +++ b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml @@ -218,6 +218,18 @@ spec: field: spec.nodepools.facets_dedicated.enable values: [true] x-ui-overrides-only: true + desired_nodes: + title: Desired Nodes + description: Desired number of worker nodes. Falls back to Min Nodes + when unset. Applied only at node pool creation (ignored on later + updates), and bounded to [Min Nodes, Max Nodes]. + type: integer + minimum: 1 + maximum: 200 + x-ui-visible-if: + field: spec.nodepools.facets_dedicated.enable + values: [true] + x-ui-overrides-only: true instance_type: title: Instance Type description: Instance type for Facets Dedicated Node Pool @@ -256,7 +268,7 @@ spec: values: [true] required: ["instance_type"] x-ui-order: [enable, instance_type, node_lifecycle_type, root_disk_volume, - max_nodes, min_nodes, ami_id, ami_name_filter, ami_owner_id] + max_nodes, min_nodes, desired_nodes, ami_id, ami_name_filter, ami_owner_id] ondemand_fallback: title: Ondemand Fallback Nodepool Spec description: Specifications of Ondemand Fallback Nodepool From 294ea96d48b47fa2eec4a634dc156a6ceda596fd Mon Sep 17 00:00:00 2001 From: Sanmesh Kakade Date: Wed, 15 Jul 2026 21:59:39 +0530 Subject: [PATCH 3/4] docs(aws_eks): desired_nodes must be within [min,max] (rejected, not clamped) Co-Authored-By: Claude Opus 4.8 (1M context) --- modules/kubernetes_cluster/aws_eks/0.2/facets.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml index 2610cb779..02317ddd7 100644 --- a/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml +++ b/modules/kubernetes_cluster/aws_eks/0.2/facets.yaml @@ -222,7 +222,7 @@ spec: title: Desired Nodes description: Desired number of worker nodes. Falls back to Min Nodes when unset. Applied only at node pool creation (ignored on later - updates), and bounded to [Min Nodes, Max Nodes]. + updates). Must be between Min Nodes and Max Nodes. type: integer minimum: 1 maximum: 200 From 40026015c3890fb63356b465d9ff6e9acff0c7c6 Mon Sep 17 00:00:00 2001 From: Sanmesh Kakade Date: Thu, 16 Jul 2026 17:21:22 +0530 Subject: [PATCH 4/4] feat(aws_eks): add min_nodes/desired_nodes to 0.1 spec too Mirror the 0.2 field additions in aws_eks 0.1 so both published versions expose facets_dedicated min/desired node counts. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../aws_eks/0.1/facets.yaml | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/modules/kubernetes_cluster/aws_eks/0.1/facets.yaml b/modules/kubernetes_cluster/aws_eks/0.1/facets.yaml index dbf4a6ebd..5c3d459f2 100644 --- a/modules/kubernetes_cluster/aws_eks/0.1/facets.yaml +++ b/modules/kubernetes_cluster/aws_eks/0.1/facets.yaml @@ -204,6 +204,31 @@ spec: field: spec.nodepools.facets_dedicated.enable values: [true] x-ui-overrides-only: true + min_nodes: + title: Min Nodes + description: Minimum number of worker nodes in the node pool. Set to + 2 or more for high availability of the platform components pinned to + this node pool. + type: integer + minimum: 1 + maximum: 200 + default: 1 + x-ui-visible-if: + field: spec.nodepools.facets_dedicated.enable + values: [true] + x-ui-overrides-only: true + desired_nodes: + title: Desired Nodes + description: Desired number of worker nodes. Falls back to Min Nodes + when unset. Applied only at node pool creation (ignored on later + updates). Must be between Min Nodes and Max Nodes. + type: integer + minimum: 1 + maximum: 200 + x-ui-visible-if: + field: spec.nodepools.facets_dedicated.enable + values: [true] + x-ui-overrides-only: true instance_type: title: Instance Type description: Instance Type of Facets Dedicated Node Pool @@ -243,7 +268,7 @@ spec: values: [true] required: ["instance_type"] x-ui-order: [enable, instance_type, node_lifecycle_type, root_disk_volume, - max_nodes, ami_id, ami_name_filter, ami_owner_id] + max_nodes, min_nodes, desired_nodes, ami_id, ami_name_filter, ami_owner_id] ondemand_fallback: title: Ondemand Fallback Nodepool Spec description: Specifications of Ondemand Fallback Nodepool