[1.21] Iris' Gambit kicks the user

[AutumnalModding]

Modloader

NeoForge

Minecraft version

1.21.1

Hex Casting version

0.12.0-devel
(note: fetched from github actions, shasum is 30d30505b6afb6ed1d709939473be527f0611dd933dd18bc5fa48951bb2764e5 hexcasting-neoforge-1.21.1-0.12.0-devel.jar)

Modloader version

NeoForge 21.1.233

Modpack info

Private modpack, unfortunately (I don't have redist perms)

The latest.log file

Nothing relevant, unfortunately. I can post if you really need, but there's zero stacktrace.

Issue description

The following pattern list, when using Iris' Gambit, will kick the player:

Replacing it with Hermes (as shown) does not run into this issue:

Note that Iris' Gambit still executes - the Jump iota is pushed, etc.
Logs have the following non-useful (probably) line: [06:22:51] [Render thread/WARN] [minecraft/ClientCommonPacketListenerImpl]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.EncoderException: Failed to encode packet 'clientbound/minecraft:custom_payload'

Steps to reproduce

i) Copy the first pattern list into a spellbook
ii) Scribe's Gambit
iii) Hold something executable in offhand
iv) Hermes' Gambit
v) Get kicked

Other information

No response

[IridescentVoid]

I believe the fix is already merged into latest 1.21, please fetch the latest CI run from https://ci.blamejared.com/job/petrakat/job/Hexcasting/job/1.21/

[AutumnalModding]

It is not - using hexcasting-neoforge-1.21.1-0.12.0-devel-pre-15 (from Last Successful Artifacts), the client is still kicked.

[s5bug]

Producing any non-empty Continuation Iota causes the issue. I'll see if I can fix it.

[s5bug]

HexMod/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/vm/SpellContinuation.kt

Line 57 in a11d4e0

Function { value: T -> Either.left(value) }

This is wrong, because it's putting NotDones in a place that expects Dones. I'll see if I can implement the TODOs in that file so the recursion isn't needed.