Skip to content

Rename/refactor fabric-side item capabilities since they don't use Cardinal Components anymore #1165

@Robotgiggle

Description

@Robotgiggle

Describe the feature

On fabric, a variety of item capabilities (media holding, hex holding, etc) that were previously implemented via Cardinal Components in 1.20 now use vanilla item components in 1.21. However, the interfaces used to interact with these components are still named and located in packages that imply a connection to Cardinal Components (ie at.petrak.hexcasting.fabric.cc.adimpl.CCMediaHolder). Furthermore, the ItemApiLookup instances used to access these interfaces are defined in HexCardinalComponents, which also implies a connection despite there no longer being any. All of this should be refactored to avoid confusion.

On a related note, there are some ComponentKeys being registered in HexCardinalComponents that are entirely unused, as their functionality has been moved over to vanilla components. These should probably be removed (unless they're somehow necessary for back-compatibility, in which case they should be deprecated).

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.21apiAPI-related enhancements/bugs/optimizationsoptimizationImprovement to existing features or performance (no new features or design work)

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions