fix block overlay crash

Author: FalsePattern

src/main/java/com/falsepattern/falsetweaks/config/ModuleConfig.java

@@ -156,11 +156,11 @@ public class ModuleConfig {
     @Config.RequiresMcRestart
     public static boolean SKY_MESH_OPTIMIZATION;
 
-    @Config.Comment("Fixes an occasional crash that happens when joining worlds due to a null-safety issue in biome code.\n" +
+    @Config.Comment("Fixes an occasional crash that happens when trying to render a GUI block overlay (more common with optifine shaders enabled.)\n" +
                     "FPS impact: Zero")
     @Config.DefaultBoolean(true)
     @Config.RequiresMcRestart
-    public static boolean GETBIOME_CRASH_FIX;
+    public static boolean OVERLAY_CRASH_FIX;
 
     static {
         ConfigurationManager.selfInit();

src/main/java/com/falsepattern/falsetweaks/mixin/mixins/client/misc/OverlayCrashFix_ItemRendererMixin.java

@@ -0,0 +1,29 @@
+package com.falsepattern.falsetweaks.mixin.mixins.client.misc;
+
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Shadow;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Redirect;
+
+import net.minecraft.client.renderer.ItemRenderer;
+import net.minecraft.init.Blocks;
+import net.minecraft.util.IIcon;
+
+@Mixin(ItemRenderer.class)
+public abstract class OverlayCrashFix_ItemRendererMixin {
+    @Shadow protected abstract void renderInsideOfBlock(float partialTickTime, IIcon blockTextureIndex);
+
+    @Redirect(method = "renderOverlays",
+              at = @At(value = "INVOKE",
+                       target = "Lnet/minecraft/client/renderer/ItemRenderer;renderInsideOfBlock(FLnet/minecraft/util/IIcon;)V"),
+              require = 0)
+    private void guardRenderInsideOfBlock(ItemRenderer instance, float partialTickTime, IIcon blockTextureIndex) {
+        if (blockTextureIndex == null) {
+            blockTextureIndex = Blocks.stone.getBlockTextureFromSide(2);
+            if (blockTextureIndex == null) {
+                return;
+            }
+        }
+        ((OverlayCrashFix_ItemRendererMixin)(Object)instance).renderInsideOfBlock(partialTickTime, blockTextureIndex);
+    }
+}

src/main/java/com/falsepattern/falsetweaks/mixin/plugin/standard/Mixin.java

@@ -328,6 +328,7 @@ public enum Mixin implements IMixin {
 
     RealmShutUp_GuiMainMenuMixin(Side.CLIENT, condition(() -> ModuleConfig.NO_REALMS_ON_MENU), "misc.RealmShutUp_GuiMainMenuMixin"),
     RealmShutUp_RealmsBridgeMixin(Side.CLIENT, condition(() -> ModuleConfig.NO_REALMS_ON_MENU), "misc.RealmShutUp_RealmsBridgeMixin"),
+    OverlayCrashFix_ItemRendererMixin(Side.CLIENT, condition(() -> ModuleConfig.OVERLAY_CRASH_FIX), "misc.OverlayCrashFix_ItemRendererMixin"),
     //endregion Misc Modules
 
     //region Particles