safer ShouldSideBeRenderedQuick

FalsePattern · FalsePattern · commit b01203e2eb5d · 2024-11-10T03:12:45.000+01:00
diff --git a/src/main/java/com/falsepattern/falsetweaks/mixin/mixins/client/triangulator/RenderBlocksUltraMixin.java b/src/main/java/com/falsepattern/falsetweaks/mixin/mixins/client/triangulator/RenderBlocksUltraMixin.java
@@ -358,7 +358,11 @@ private int getBlockMetadataOffset(int x, int y, int z, Vector3ic offset) {
     }
 
     private boolean shouldSideBeRenderedQuick(Block block, int x, int y, int z, Facing facing) {
-        return block.shouldSideBeRendered(blockAccess, x + facing.front.x(), y + facing.front.y(), z + facing.front.z(), facing.face.ordinal());
+        try {
+            return block.shouldSideBeRendered(blockAccess, x + facing.front.x(), y + facing.front.y(), z + facing.front.z(), facing.face.ordinal());
+        } catch (Throwable ignored) {
+            return true;
+        }
     }
 
     private boolean renderFace(Facing facing) {

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,11 @@ private int getBlockMetadataOffset(int x, int y, int z, Vector3ic offset) {`
`358`	`358`	`}`
`359`	`359`
`360`	`360`	`private boolean shouldSideBeRenderedQuick(Block block, int x, int y, int z, Facing facing) {`
`361`		`- return block.shouldSideBeRendered(blockAccess, x + facing.front.x(), y + facing.front.y(), z + facing.front.z(), facing.face.ordinal());`
	`361`	`+ try {`
	`362`	`+ return block.shouldSideBeRendered(blockAccess, x + facing.front.x(), y + facing.front.y(), z + facing.front.z(), facing.face.ordinal());`
	`363`	`+ } catch (Throwable ignored) {`
	`364`	`+ return true;`
	`365`	`+ }`
`362`	`366`	`}`
`363`	`367`
`364`	`368`	`private boolean renderFace(Facing facing) {`