Skip to content

[E7] SmolVLA export self-validation computes PASS/FAIL but never gates; threshold far too loose #273

Description

@DsThakurRawat

Labels: bug, export, parity, priority:medium
File: src/tether/exporters/smolvla.py:278

Description. result["metadata"]["onnx_validation"] = {"max_diff": max_diff, "passed": max_diff < 0.01} is only stored, never enforced; export returns ok even when passed is False. 0.01 is orders of magnitude looser than an FP32 round-trip (~1e-5).

Tasks.

  • Fail/mark the export when max_diff exceeds a tight FP32 tolerance; tighten the threshold.

Dedup. Not covered. (#241 fixes SmolVLA SiLU activation — different bug in the same file.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions