Skip to content

Commit 2e13d33

Browse files
committed
fix(test): assert gRPC status code directly instead of matching message text
1 parent 495e25f commit 2e13d33

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

framework/src/test/java/org/tron/core/services/RpcApiServicesTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.google.protobuf.Any;
99
import com.google.protobuf.ByteString;
10+
import io.grpc.Status;
1011
import io.grpc.StatusRuntimeException;
1112
import io.grpc.ManagedChannel;
1213
import io.grpc.ManagedChannelBuilder;
@@ -584,7 +585,7 @@ public void testScanNoteByIvkRejectsInvalidLength() {
584585
blockingStubFull.scanNoteByIvk(message);
585586
Assert.fail("Expected INVALID_ARGUMENT");
586587
} catch (StatusRuntimeException e) {
587-
Assert.assertTrue(e.getMessage().contains("INVALID_ARGUMENT"));
588+
Assert.assertEquals(Status.Code.INVALID_ARGUMENT, e.getStatus().getCode());
588589
}
589590
}
590591

@@ -602,7 +603,7 @@ public void testScanAndMarkNoteByIvkRejectsInvalidLength() {
602603
blockingStubFull.scanAndMarkNoteByIvk(message);
603604
Assert.fail("Expected INVALID_ARGUMENT");
604605
} catch (StatusRuntimeException e) {
605-
Assert.assertTrue(e.getMessage().contains("INVALID_ARGUMENT"));
606+
Assert.assertEquals(Status.Code.INVALID_ARGUMENT, e.getStatus().getCode());
606607
}
607608
}
608609

@@ -620,7 +621,7 @@ public void testScanShieldedTRC20NotesByIvkRejectsInvalidLength() {
620621
blockingStubFull.scanShieldedTRC20NotesByIvk(message);
621622
Assert.fail("Expected INVALID_ARGUMENT");
622623
} catch (StatusRuntimeException e) {
623-
Assert.assertTrue(e.getMessage().contains("INVALID_ARGUMENT"));
624+
Assert.assertEquals(Status.Code.INVALID_ARGUMENT, e.getStatus().getCode());
624625
}
625626
}
626627

@@ -636,7 +637,7 @@ public void testScanShieldedTRC20NotesByOvkRejectsInvalidLength() {
636637
blockingStubFull.scanShieldedTRC20NotesByOvk(message);
637638
Assert.fail("Expected INVALID_ARGUMENT");
638639
} catch (StatusRuntimeException e) {
639-
Assert.assertTrue(e.getMessage().contains("INVALID_ARGUMENT"));
640+
Assert.assertEquals(Status.Code.INVALID_ARGUMENT, e.getStatus().getCode());
640641
}
641642
}
642643

0 commit comments

Comments
 (0)