Skip to content

Commit 32df40f

Browse files
cesinecesine
committed
fix lint in test
1 parent db091e4 commit 32df40f

14 files changed

Lines changed: 76 additions & 55 deletions

File tree

‎models/oauth-token.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ function read(token, callback) {
8888
/**
8989
* List oauth token matching the options
9090
* @param {Object} options [description]
91-
* @return {Promise} [description]
91+
* @return {Promise} [description] // TODO why converting promise to callback?
9292
*/
9393
function list(options, callback) {
9494
const opts = lodash.assign({

‎test/auth-service-spec.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const { expect } = require('chai');
22

3+
// eslint-disable-next-line global-require
34
const service = process.env.URL || require('../auth_service');
45

56
describe('auth_service', () => {

‎test/integration/authentication.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ const { expect } = require('chai');
22
const supertest = require('supertest');
33
const AsToken = require('../../lib/token');
44

5+
// eslint-disable-next-line global-require
56
const service = process.env.URL || require('../../auth_service');
67
const User = require('../../models/user');
78

‎test/integration/install.js‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ const replay = require('replay');
55
const supertest = require('supertest');
66
const url = require('url');
77

8+
// eslint-disable-next-line no-underscore-dangle
89
const originalLocalhosts = replay._localhosts;
10+
// eslint-disable-next-line no-underscore-dangle
911
debug('replay localhosts', replay._localhosts);
1012

1113
let destination = 'http://admin:none@localhost:5984';
@@ -20,11 +22,15 @@ debug('source', source);
2022

2123
describe('install', () => {
2224
before(() => {
25+
// eslint-disable-next-line no-underscore-dangle
2326
replay._localhosts = new Set();
27+
// eslint-disable-next-line no-underscore-dangle
2428
debug('before replay localhosts', replay._localhosts);
2529
});
2630
after(() => {
31+
// eslint-disable-next-line no-underscore-dangle
2732
replay._localhosts = originalLocalhosts;
33+
// eslint-disable-next-line no-underscore-dangle
2834
debug('after replay localhosts', replay._localhosts);
2935
});
3036

@@ -217,6 +223,7 @@ describe('install', () => {
217223
.send(doc);
218224
})
219225
.then((res) => {
226+
// eslint-disable-next-line no-underscore-dangle
220227
if (res.body._id) {
221228
expect(res.status).to.equal(200);
222229
} else {
@@ -277,6 +284,7 @@ describe('install', () => {
277284
.send(doc);
278285
})
279286
.then((res) => {
287+
// eslint-disable-next-line no-underscore-dangle
280288
if (res.body._id) {
281289
expect(res.status).to.equal(200);
282290
} else {

‎test/integration/oauth.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const AsToken = require('../../lib/token');
21
const debug = require('debug')('test:integration:oauth');
32
const { expect } = require('chai');
43
const Express = require('express');
@@ -9,8 +8,10 @@ const session = require('express-session');
98
const supertest = require('supertest');
109
const url = require('url');
1110

12-
const service = process.env.URL || require('../../auth_service');
11+
const AsToken = require('../../lib/token');
1312
const OauthClient = require('../../models/oauth-client');
13+
// eslint-disable-next-line global-require
14+
const service = process.env.URL || require('../../auth_service');
1415
const UserModel = require('../../models/user');
1516

1617
const fixtures = {
@@ -257,7 +258,6 @@ describe('/oauth2', () => {
257258
.set('Authorization', res.headers.authorization);
258259
})
259260
.then((res) => {
260-
let callbackUrl;
261261
debug('after authorize in res.body', res.body);
262262
debug('after authorize in res.headers', res.headers);
263263
expect(res.status).to.equal(302, res.text);
@@ -291,7 +291,7 @@ describe('/oauth2', () => {
291291
});
292292

293293
// Follow redirect back to client
294-
callbackUrl = res.headers.location.replace('http://localhost:8011', '');
294+
const callbackUrl = res.headers.location.replace('http://localhost:8011', '');
295295
debug('callbackUrl', callbackUrl);
296296
return supertest(clientServer)
297297
.get(callbackUrl)

‎test/integration/service.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
const { expect } = require('chai');
22
const supertest = require('supertest');
33

4+
// eslint-disable-next-line global-require
45
const service = process.env.URL || require('../../auth_service');
56

67
describe('/v1', () => {

‎test/integration/users.js‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,29 @@
1-
const debug = require('debug')('test:install');
1+
const debug = require('debug')('test:integration:users');
22
const {
33
expect,
44
} = require('chai');
55
const path = require('path');
66
const replay = require('replay');
77
const supertest = require('supertest');
8+
// eslint-disable-next-line global-require
89
const authWebService = process.env.URL || require('../../auth_service');
910

11+
// eslint-disable-next-line no-underscore-dangle
1012
const originalLocalhosts = replay._localhosts;
1113
const requestId = 'deprecated-spec';
1214
replay.fixtures = path.join(__dirname, '/../fixtures/replay');
1315

1416
describe.skip('/users', () => {
1517
before(() => {
18+
// eslint-disable-next-line no-underscore-dangle
1619
replay._localhosts = new Set(['127.0.0.1', '::1']);
20+
// eslint-disable-next-line no-underscore-dangle
1721
debug('before replay localhosts', replay._localhosts);
1822
});
1923
after(() => {
24+
// eslint-disable-next-line no-underscore-dangle
2025
replay._localhosts = originalLocalhosts;
26+
// eslint-disable-next-line no-underscore-dangle
2127
debug('after replay localhosts', replay._localhosts);
2228
});
2329

‎test/integration/v1/users.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
const { expect } = require('chai');
22
const supertest = require('supertest');
33

4+
// eslint-disable-next-line global-require
45
const api = process.env.URL || require('../../../auth_service');
56
const user = require('../../../models/user');
7+
const userFixtures = require('../../fixtures/user.json');
68

79
const fixtures = {
8-
user: require('../../fixtures/user.json'),
10+
user: userFixtures,
911
};
1012

1113
describe('/v1/users', () => {

‎test/lib/token-spec.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1+
const debug = require('debug')('test:lib:token');
12
const { expect } = require('chai');
23

3-
const AsToken = exports.AsToken || require('../../lib/token');
4+
const AsToken = require('../../lib/token');
45

56
describe('AsToken', () => {
67
it('should load', () => {
@@ -71,7 +72,7 @@ describe('AsToken', () => {
7172

7273
it('should verify the token and return contents', () => {
7374
const bearerToken = `Bearer ${AsToken.sign(json)}`;
74-
console.log(bearerToken);
75+
debug(bearerToken);
7576

7677
const decoded = AsToken.verify(bearerToken);
7778
expect(decoded).to.deep.equal({

‎test/lib/user-spec.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,21 @@ const {
2121
verifyPassword,
2222
} = require('../../lib/user');
2323

24+
// eslint-disable-next-line no-underscore-dangle
2425
const originalLocalhosts = replay._localhosts;
2526
replay.fixtures = path.join(__dirname, '../fixtures/replay');
2627

2728
describe('lib/user', () => {
2829
before(() => {
30+
// eslint-disable-next-line no-underscore-dangle
2931
replay._localhosts = new Set(['127.0.0.1', '::1']);
32+
// eslint-disable-next-line no-underscore-dangle
3033
debug('before replay localhosts', replay._localhosts);
3134
});
3235
after(() => {
36+
// eslint-disable-next-line no-underscore-dangle
3337
replay._localhosts = originalLocalhosts;
38+
// eslint-disable-next-line no-underscore-dangle
3439
debug('after replay localhosts', replay._localhosts);
3540
});
3641

0 commit comments

Comments
 (0)