e2es are now testing the app inside the docker container

Author: cesine

.github/workflows/node.js.yml

@@ -36,6 +36,14 @@ jobs:
     - name: Run Integration tests
       run: DEBUG=replay* npm run coverage || echo 'Test run failed replay no longer is working with latest nano which uses node fetch'
 
+    - name: Upload coverage report
+      uses: actions/upload-artifact@v5
+      if: success() || failure()
+      with:
+        name: coverage
+        path: coverage/
+        retention-days: 3
+
     - name: Start docker compose services
       run: docker compose up -d && sleep 5
 
@@ -54,6 +62,10 @@ jobs:
         SOURCE_URL: ${{ secrets.SOURCE_URL }}
         DEBUG: 'none'
 
+    - name: Show docker compose logs
+      if: success() || failure()
+      run: docker compose logs --no-color --timestamps || true
+
     - name: Coveralls
       if: success() || failure()
       uses: coverallsapp/github-action@master

nyc.config.js

@@ -10,5 +10,5 @@ module.exports = {
   functions: 65,
   lines: 76,
   statements: 76,
-  reporter: ['text', 'lcov'],
+  reporter: ['html', 'text', 'lcov'],
 };

package.json

@@ -62,7 +62,7 @@
   },
   "scripts": {
     "docker:build": "docker build -t fielddb-auth .",
-    "test:integration": "echo 'module.exports = { usersDbConnection: { url: \"http://couchdb:5984\" } };' > config/local.js && docker compose up -d && sleep 3 && docker compose logs && npm run setup && npm run test:deprecated",
+    "test:e2e": "echo 'module.exports = { usersDbConnection: { url: \"http://couchdb:5984\" } };' > config/local.js && docker compose up -d && sleep 3 && docker compose logs && npm run setup && npm run test:deprecated",
     "docker:test:no-cache": "echo 'module.exports = { usersDbConnection: { url: \"http://couchdb:5984\" } };' > config/local.js && docker compose build --no-cache && docker compose up -d && sleep 15 && docker compose logs && npm run setup && npm run test:deprecated",
     "coverage": "NODE_ENV=test BUNYAN_LOG_LEVEL=FATAL nyc npm test",
     "lint": "eslint ",
@@ -71,7 +71,7 @@
     "start": "node ./bin/www.js",
     "test": "SOURCE_URL=${SOURCE_URL:-https://public:none@corpusdev.example.org} NODE_ENV=test NODE_TLS_REJECT_UNAUTHORIZED=0 mocha --timeout 100000 --recursive test",
     "test:debug": "node-debug _mocha test/integration/oauth.js",
-    "test:deprecated": "DEBUG=${DEBUG:-lib:user} REPLAY=bloody NODE_TLS_REJECT_UNAUTHORIZED=0 URL=https://localhost:3183 nyc mocha --timeout 25000 test/routes/deprecated-spec.js",
+    "test:deprecated": "DEBUG=${DEBUG:-lib:user} REPLAY=bloody NODE_TLS_REJECT_UNAUTHORIZED=0 URL=https://localhost:3183 mocha --timeout 25000 test/routes/deprecated-spec.js",
     "test:fielddb": "NODE_ENV=localhost jasmine-node node_modules/fielddb/tests",
     "test:production": "ls config/production.js",
     "watch": "nodemon ./bin/www.js"