Merge pull request #72 from cesine/more_lint

use eslint:recommended

Author: cesine

.babelrc

@@ -2,7 +2,6 @@
   "presets": ["es2015", "react"],
   "env": {
     "test": {
-      "plugins": [ "babel-plugin-rewire" ]
     }
   }
 }

.eslintrc

@@ -1,23 +1,20 @@
 {
   "parser": "babel-eslint",
   "extends": [
-    "standard",
-    "standard-react"
+    "eslint:recommended",
+    "plugin:mocha/recommended",
+    "plugin:react/recommended"
   ],
   "plugins": [
-    "babel",
-    "react",
-    "promise"
+    "mocha",
+    "react"
   ],
   "env": {
-    "mocha" : true
+    "mocha": true,
+    "node": true
   },
   "globals": {
-    "document": false,
-    "expect": false,
-    "navigator": false,
-    "sinon": false,
-    "window": false
+    "Symbol": false
   },
   "rules": {}
 }

app/app.js

@@ -1,3 +1,4 @@
+/* global window, document */
 import 'babel-polyfill'
 import { browserHistory } from 'react-router'
 import Immutable from 'immutable'
@@ -17,6 +18,7 @@ if (window.__REDUX_STATE__) {
       reduxState[key] = Immutable.fromJS(val)
     })
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error(e)
   }
 }
@@ -27,4 +29,4 @@ ReactDOM.render((
   <Provider store={store}>
     { createRoutes(browserHistory) }
   </Provider>
-  ), document.getElementById('root'))
+), document.getElementById('root'))

app/components/App/index.jsx

@@ -3,22 +3,23 @@ import { FieldDBObject } from 'fielddb/api/FieldDBObject'
 import Helmet from 'react-helmet'
 import Q from 'q'
 import React, { Component } from 'react'
+import PropTypes from 'prop-types'
 
 FieldDBObject.todo = function () {}
 FieldDBObject.warn = function () {}
 FieldDBObject.confirm = function (message, optionalLocale) {
   const deferred = Q.defer()
-  console.warn('Not confirming: ', message)
+  // console.warn('Not confirming: ', message)
   deferred.reject({
     message: message,
     optionalLocale: optionalLocale,
     response: null
   })
   return deferred.promise
 }
-FieldDBObject.prompt = function (message, optionalLocale, providedInput) {
+FieldDBObject.prompt = function (message, optionalLocale) {
   const deferred = Q.defer()
-  console.warn('Not prompting: ', message)
+  // console.warn('Not prompting: ', message)
   deferred.reject({
     message: message,
     optionalLocale: optionalLocale,
@@ -47,18 +48,18 @@ class App extends Component {
           htmlAttributes={{
             'lang': 'en'
           }}
-      />
+        />
         {this.props.children}
       </div>
     )
   }
 }
 
 App.propTypes = {
-  children: React.PropTypes.object.isRequired
+  children: PropTypes.object.isRequired
 }
 
-function mapStateToProps (state) {
+function mapStateToProps () {
   return {}
 }
 

app/components/App/routes.js

@@ -7,7 +7,7 @@ import CorpusMaskContainer from '../CorpusMask'
 import UserMaskContainer from '../UserMask'
 import SearchContainer from '../Search'
 
-export default function (history) {
+export default function Routes(history) {
   return (
     <Router history={history}>
       <Route path='/' component={App}>

app/components/App/store.js

@@ -9,14 +9,15 @@ const logger = createLogger({
   level: 'info',
   collapsed: false,
   logger: console,
-  predicate: (getState, action) => true
+  predicate: () => true
 })
 
 let middlewares = [
   thunkMiddleware,
   apiMiddleware
 ]
 
+// By default: debug all state changes if in development mode
 if (process.env.NODE_ENV !== 'production') {
   middlewares = [...middlewares, logger]
 }

app/components/Corpora/Corpora.jsx

@@ -1,4 +1,5 @@
 import React, { Component } from 'react'
+import PropTypes from 'prop-types'
 import { Link } from 'react-router'
 import { List } from 'immutable'
 
@@ -8,38 +9,38 @@ class Corpora extends Component {
       <div className={this.props.className}>
         <h1>Corpora</h1>
         {
-      this.props.corpora.map((connection) => {
-        let website = connection.get('website') || ''
-        if (connection.get('searchKeywords')) {
-          website = `${website}/search/${connection.get('searchKeywords')}`
-        } else {
-          website = `${website}/search`
-        }
-        return (
-          <div className='media' key={connection.get('dbname')}>
-            <Link to={website} className='pull-left'>
-              <img src={'https://secure.gravatar.com/avatar/' + connection.get('gravatar') + '.jpg?s=96&d=retro&r=pg'} alt='Corpus image' className='media-object' />
-            </Link>
-            <div className='media-body'>
-              <h4 className='media-heading'>
-                <Link to={website}>
-                  {connection.get('title')}
+          this.props.corpora.map((connection) => {
+            let website = connection.get('website') || ''
+            if (connection.get('searchKeywords')) {
+              website = `${website}/search/${connection.get('searchKeywords')}`
+            } else {
+              website = `${website}/search`
+            }
+            return (
+              <div className='media' key={connection.get('dbname')}>
+                <Link to={website} className='pull-left'>
+                  <img src={'https://secure.gravatar.com/avatar/' + connection.get('gravatar') + '.jpg?s=96&d=retro&r=pg'} alt='Corpus image' className='media-object' />
                 </Link>
-              </h4>
-              <p>{connection.get('description')}</p>
-            </div>
-          </div>
-        )
-      })
-      }
+                <div className='media-body'>
+                  <h4 className='media-heading'>
+                    <Link to={website}>
+                      {connection.get('title')}
+                    </Link>
+                  </h4>
+                  <p>{connection.get('description')}</p>
+                </div>
+              </div>
+            )
+          })
+        }
       </div>
     )
   }
 }
 
 Corpora.propTypes = {
-  corpora: React.PropTypes.instanceOf(List).isRequired,
-  className: React.PropTypes.string.isRequired
+  corpora: PropTypes.instanceOf(List).isRequired,
+  className: PropTypes.string.isRequired
 }
 
 export default Corpora

app/components/Corpora/Corpora.test.js

@@ -1,12 +1,18 @@
+import { expect } from 'chai'
 import Immutable from 'immutable'
 import { Link } from 'react-router'
 import React from 'react'
 import { shallow } from 'enzyme'
 
 import Corpora from './Corpora.jsx'
 
+function renderDoc (props) {
+  return shallow(<Corpora {...props} />)
+}
+
 describe('Component::Corpora', function () {
-  let props
+  let props;
+
   beforeEach(function () {
     props = {
       corpora: Immutable.fromJS([
@@ -27,12 +33,9 @@ describe('Component::Corpora', function () {
       ])
     }
   })
-  function renderDoc () {
-    return shallow(<Corpora {...props} />)
-  }
 
   it('renders corpora', function () {
-    let doc = renderDoc()
+    let doc = renderDoc(props)
     let corpusMaskComps = doc.find(Link)
 
     expect(corpusMaskComps.length).to.equal(props.corpora.size * 2)

app/components/Corpora/CorporaContainer.test.js

@@ -1,6 +1,8 @@
+import { expect } from 'chai'
 import Immutable from 'immutable'
 import React from 'react'
 import { shallow } from 'enzyme'
+import sinon from 'sinon'
 
 import Corpora from './Corpora.jsx'
 import { CorpusMaskContainer } from './index.jsx'

app/components/Corpora/actions.test.js

@@ -1,3 +1,4 @@
+import { expect } from 'chai'
 import { CALL_API } from 'middleware/api'
 
 import * as actionCreator from './actions'