sonar finding on redundant toString

R-Sandor · R-Sandor · commit 2c5ba0ee53e0 · 2025-12-06T13:00:55.000-05:00
diff --git a/server/src/test/java/dev/findfirst/security/oauth2/Oauth2LoginSuccessHandlerTest.java b/server/src/test/java/dev/findfirst/security/oauth2/Oauth2LoginSuccessHandlerTest.java
@@ -65,7 +65,7 @@ void authenticateGithubUser() throws Exception {
   }
 
   private void authenticateUserByProvider(String provider) throws Exception {
-    OAuth2AuthenticationToken oAuthToken = mockAuthentication(provider.toString().toLowerCase(), ID).getFirst();
+    OAuth2AuthenticationToken oAuthToken = mockAuthentication(provider.toLowerCase(), ID).getFirst();
 
     MockHttpServletResponse response = new MockHttpServletResponse();
     oAuthHandler.onAuthenticationSuccess(new MockHttpServletRequest(), response, oAuthToken);

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ void authenticateGithubUser() throws Exception {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`private void authenticateUserByProvider(String provider) throws Exception {`
`68`		`- OAuth2AuthenticationToken oAuthToken = mockAuthentication(provider.toString().toLowerCase(), ID).getFirst();`
	`68`	`+ OAuth2AuthenticationToken oAuthToken = mockAuthentication(provider.toLowerCase(), ID).getFirst();`
`69`	`69`
`70`	`70`	`MockHttpServletResponse response = new MockHttpServletResponse();`
`71`	`71`	`oAuthHandler.onAuthenticationSuccess(new MockHttpServletRequest(), response, oAuthToken);`