More sonar findings

R-Sandor · R-Sandor · commit a3df897efc7e · 2025-05-05T06:26:51.000-04:00
diff --git a/server/src/main/java/dev/findfirst/core/service/TypesenseService.java b/server/src/main/java/dev/findfirst/core/service/TypesenseService.java
@@ -31,7 +31,7 @@ public class TypesenseService {
 
   private final Client client;
 
-  private final String schemaName = "bookmark";
+  private final static String schemaName = "bookmark";
 
   @PostConstruct
   public String createSchema() {
diff --git a/server/src/main/java/dev/findfirst/users/controller/UserController.java b/server/src/main/java/dev/findfirst/users/controller/UserController.java
@@ -184,7 +184,8 @@ public ResponseEntity<String> uploadProfilePicture(
     }
 
     try {
-      User user = userService.getUserById(uContext.getUserId()).orElseThrow(NoUserFoundException::new);
+      User user =
+          userService.getUserById(uContext.getUserId()).orElseThrow(NoUserFoundException::new);
       userService.changeUserPhoto(user, file);
 
       return ResponseEntity.ok("File uploaded successfully.");
@@ -202,7 +203,7 @@ public ResponseEntity<Resource> getUserProfilePicture(@RequestParam("userId") in
       var opt = userService.getUserById(userId);
       if (opt.isEmpty()) {
         return ResponseEntity.status(HttpStatus.NOT_FOUND).body(null);
-      } 
+      }
 
       String userPhotoPath = opt.get().getUserPhoto();
 
diff --git a/server/src/test/java/dev/findfirst/core/controller/BookmarkControllerTest.java b/server/src/test/java/dev/findfirst/core/controller/BookmarkControllerTest.java
@@ -454,7 +454,7 @@ void importBookmarks() throws IOException {
    * Tests importing a file with an invalid content type (not text/html).
    */
   @Test
-  void importBookmarksWithInvalidContentType() throws IOException {
+  void importBookmarksWithInvalidContentType() {
     // Create a byte array with text/plain content type
     byte[] fileContent = "<html><body>Test Content</body></html>".getBytes(StandardCharsets.UTF_8);
 
@@ -484,7 +484,7 @@ void importBookmarksWithInvalidContentType() throws IOException {
    * Tests importing a file that exceeds the maximum allowed size of 250MB.
    */
   @Test
-  void importBookmarksWithFileTooLarge() throws IOException {
+  void importBookmarksWithFileTooLarge() {
     // Create a byte array slightly larger than 250MB (31,250,001 bytes)
     byte[] largeFile = new byte[31_250_001];
 
@@ -515,7 +515,7 @@ void importBookmarksWithFileTooLarge() throws IOException {
    * Tests importing a .html file with an unsupported content type (e.g., application/json).
    */
   @Test
-  void importBookmarksWithUnsupportedContentType() throws IOException {
+  void importBookmarksWithUnsupportedContentType() {
     // Create a byte array with application/json content
     byte[] fileContent = "{\"bookmarks\": []}".getBytes(StandardCharsets.UTF_8);
 
@@ -548,7 +548,7 @@ void importBookmarksWithUnsupportedContentType() throws IOException {
    * Tests importing a .html file without specifying a content type.
    */
   @Test
-  void importBookmarksWithMissingContentType() throws IOException {
+  void importBookmarksWithMissingContentType() {
     // Create a byte array with valid HTML content
     byte[] fileContent = "<html><body>Test Content</body></html>".getBytes(StandardCharsets.UTF_8);
 
@@ -580,7 +580,7 @@ void importBookmarksWithMissingContentType() throws IOException {
    * Tests importing a .html file with text/plain content type.
    */
   @Test
-  void importBookmarksWithTextPlainContentType() throws IOException {
+  void importBookmarksWithTextPlainContentType() {
     // Create a byte array with text/plain content
     byte[] fileContent =
         "<html><body>Plain Text Content</body></html>".getBytes(StandardCharsets.UTF_8);
diff --git a/server/src/test/java/dev/findfirst/core/service/TypesenseServiceTest.java b/server/src/test/java/dev/findfirst/core/service/TypesenseServiceTest.java
@@ -77,7 +77,5 @@ void initializationWasNotFinished() throws Exception {
 
   @Test
   @Disabled("Implement test to save storeScrapedText")
-  void storeScrapedText() throws Exception {
-
-  }
+  void storeScrapedText() throws Exception {}
 }
diff --git a/server/src/test/java/dev/findfirst/security/util/KeyGeneratorTest.java b/server/src/test/java/dev/findfirst/security/util/KeyGeneratorTest.java
@@ -74,12 +74,12 @@ void testGenerateKeysProducesDifferentKeysOnSeparateRuns()
     String pubKeyContent1 = Files.readString(publicKeyPath1);
     String pubKeyContent2 = Files.readString(publicKeyPath2);
 
-    String pubKeyBase64_1 = pubKeyContent1.replace("-----BEGIN PUBLIC KEY-----", "")
+    String pubKeyBase64One = pubKeyContent1.replace("-----BEGIN PUBLIC KEY-----", "")
         .replace("-----END PUBLIC KEY-----", "").replaceAll("\\s", "");
-    String pubKeyBase64_2 = pubKeyContent2.replace("-----BEGIN PUBLIC KEY-----", "")
+    String pubKeyBase64Two = pubKeyContent2.replace("-----BEGIN PUBLIC KEY-----", "")
         .replace("-----END PUBLIC KEY-----", "").replaceAll("\\s", "");
 
-    assertNotEquals(pubKeyBase64_1, pubKeyBase64_2, "Each generated public key should be unique");
+    assertNotEquals(pubKeyBase64One, pubKeyBase64Two, "Each generated public key should be unique");
 
   }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,5 @@ void initializationWasNotFinished() throws Exception {`
`77`	`77`
`78`	`78`	`@Test`
`79`	`79`	`@Disabled("Implement test to save storeScrapedText")`
`80`		`- void storeScrapedText() throws Exception {`
`81`		`-`
`82`		`- }`
	`80`	`+ void storeScrapedText() throws Exception {}`
`83`	`81`	`}`