Clipboard access toast: Improvements [1/2]

* Add settings observer. Duh?
* Make string translatable.
* Priortize alerts: 1 - show important alerts, 2 - show all alerts
* Make use of Toast.cancel()

@neobuddy89:
Intentionally skipping commit " ClipboardService: keep track of which app pasted from which"
It is weird commit which works sometimes and throws odd messages like "Whatsapp pasted from Whatsapp"
Old implementation is better and this commit should make it smarter.

Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
Change-Id: I7c09d450db6200693d44044c7dbc93e12098364a

Author: neobuddy89

core/java/android/provider/Settings.java

@@ -5323,10 +5323,10 @@ public boolean validate(@Nullable String value) {
         public static final String QS_QUICKBAR_COLUMNS = "qs_quickbar_columns";
 
         /**
-         * Toggle for clipboard access toast.
+         * Clipboard access info
          * @hide
          */
-        public static final String SHOW_CLIPBOARD_TOAST = "show_clipboard_toast";
+        public static final String CLIPBOARD_TOAST_INFO = "clipboard_toast_info";
 
         /**
          * Settings to backup. This is here so that it's in the same place as the settings

core/res/res/values/fh_strings.xml

@@ -45,4 +45,8 @@
 
     <!-- Screen recorder -->
     <string name="global_action_screenrecord">Screenrecord</string>
+
+    <!-- Clipboard access toast -->
+    <string name="app_clipboard_access_denied">%1$s tried to access the clipboard and was denied</string>
+    <string name="app_clipboard_access_granted">%1$s tried to access the clipboard and was granted</string>
 </resources>

core/res/res/values/fh_symbols.xml

@@ -155,4 +155,8 @@
 
   <!-- Post reset runnable for all clients -->
   <java-symbol type="array" name="config_blockPackagesSensorDrain" />
+
+  <!-- Clipboard access toast -->
+  <java-symbol type="string" name="app_clipboard_access_denied" />
+  <java-symbol type="string" name="app_clipboard_access_granted" />
 </resources>

services/core/java/com/android/server/clipboard/ClipboardService.java

@@ -42,6 +42,7 @@
 import android.content.pm.PackageManager;
 import android.content.pm.PackageManager.NameNotFoundException;
 import android.content.pm.UserInfo;
+import android.database.ContentObserver;
 import android.net.Uri;
 import android.os.Binder;
 import android.os.Handler;
@@ -180,6 +181,12 @@ public class ClipboardService extends SystemService {
 
     private final SparseArray<PerUserClipboard> mClipboards = new SparseArray<>();
 
+    private SettingsObserver mSettingsObserver;
+    private int mShouldToast;
+    private Handler mHandler;
+    private String mToastMessage;
+    private Toast mToast;
+
     /**
      * Instantiates the clipboard.
      */
@@ -215,6 +222,30 @@ public void onHostClipboardUpdated(String contents){
             mHostMonitorThread = new Thread(mHostClipboardMonitor);
             mHostMonitorThread.start();
         }
+
+        mHandler = new Handler();
+
+        mSettingsObserver = new SettingsObserver();
+        mSettingsObserver.update();
+    }
+
+    private class SettingsObserver extends ContentObserver {
+        SettingsObserver() {
+            super(mHandler);
+            getContext().getContentResolver().registerContentObserver(Settings.System.getUriFor(
+                    Settings.System.CLIPBOARD_TOAST_INFO),
+                    false, this, UserHandle.USER_ALL);
+        }
+
+        @Override
+        public void onChange(boolean selfChange) {
+            update();
+        }
+
+        public void update() {
+            mShouldToast = Settings.System.getIntForUser(getContext().getContentResolver(),
+                    Settings.System.CLIPBOARD_TOAST_INFO, 0, UserHandle.USER_CURRENT);
+        }
     }
 
     @Override
@@ -743,43 +774,70 @@ private final void revokeUris(PerUserClipboard clipboard) {
         }
     }
 
+    private Runnable mRunnable = new Runnable() {
+        @Override
+        public void run() {
+            String msg = mToastMessage;
+
+            if (msg.isEmpty())
+                return;
+
+            if (mToast != null) {
+                mToast.cancel();
+                mToast = null;
+            }
+            mToast = Toast.makeText(getContext(), msg, Toast.LENGTH_SHORT);
+            mToast.show();
+        }
+    };
+
     private boolean clipboardAccessAllowed(int op, String callingPackage, int uid,
             @UserIdInt int userId) {
-        final String prefName = "show_clipboard_toast";
-        boolean shouldToast = Settings.System.getInt(getContext().getContentResolver(), prefName, 0) == 1;
-        if (shouldToast) {
-            // create toast that app has tried to access clipboard
-            final PackageManager pm = getContext().getPackageManager();
-            ApplicationInfo ai;
+        Context context = getContext();
+        String applicationName = "(unknown)";
+        mToastMessage = "";
+
+        if (mShouldToast > 0) {
+            final PackageManager pm = context.getPackageManager();
+            ApplicationInfo ai = null;
             try {
                 ai = pm.getApplicationInfo(callingPackage, 0);
+                if (ai != null) applicationName = pm.getApplicationLabel(ai).toString();
             } catch (final NameNotFoundException e) {
-                ai = null;
+                // Do nothing
             }
-            final String applicationName = (String) (ai != null ? pm.getApplicationLabel(ai) : "(unknown)");
-            Handler handler = new Handler(Looper.getMainLooper());
-            handler.post(new Runnable() {
-                @Override
-                public void run() {
-                    Toast.makeText(getContext(), applicationName + " tried to access the clipboard", Toast.LENGTH_SHORT).show();
-                }
-            });
         }
+
         // Check the AppOp.
         if (mAppOps.noteOp(op, uid, callingPackage) != AppOpsManager.MODE_ALLOWED) {
+            if (mShouldToast > 0) {
+                mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_denied),
+                    applicationName);
+                mHandler.post(mRunnable);
+            }
             return false;
         }
         // Shell can access the clipboard for testing purposes.
         if (mPm.checkPermission(android.Manifest.permission.READ_CLIPBOARD_IN_BACKGROUND,
                     callingPackage) == PackageManager.PERMISSION_GRANTED) {
+            if (mShouldToast > 1) {
+                mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_granted),
+                    applicationName);
+                mHandler.post(mRunnable);
+            }
             return true;
         }
         // The default IME is always allowed to access the clipboard.
-        String defaultIme = Settings.Secure.getStringForUser(getContext().getContentResolver(),
+        String defaultIme = Settings.Secure.getStringForUser(context.getContentResolver(),
                 Settings.Secure.DEFAULT_INPUT_METHOD, userId);
         if (!TextUtils.isEmpty(defaultIme)) {
             final String imePkg = ComponentName.unflattenFromString(defaultIme).getPackageName();
             if (imePkg.equals(callingPackage)) {
+                if (mShouldToast > 1) {
+                    mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_granted),
+                        applicationName);
+                    mHandler.post(mRunnable);
+                }
                 return true;
             }
         }
@@ -816,9 +874,23 @@ public void run() {
                             + ", application is not in focus neither is a system service for "
                             + "user " + userId);
                 }
+                if (mShouldToast > 0 && allowed) {
+                    mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_granted),
+                        applicationName);
+                    mHandler.post(mRunnable);
+                } else if (mShouldToast > 0 && !allowed) {
+                    mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_denied),
+                        applicationName);
+                    mHandler.post(mRunnable);
+                }
                 return allowed;
             case AppOpsManager.OP_WRITE_CLIPBOARD:
                 // Writing is allowed without focus.
+                if (mShouldToast > 0) {
+                    mToastMessage = String.format(context.getResources().getString(com.android.internal.R.string.app_clipboard_access_granted),
+                        applicationName);
+                    mHandler.post(mRunnable);
+                }
                 return true;
             default:
                 throw new IllegalArgumentException("Unknown clipboard appop " + op);