Address code review: use .copy() for sort output, use ones() in tests

Agent-Logs-Url: https://github.com/FlorianPfaff/PyRecEst/sessions/31c921c4-c991-44f5-89c7-ee929e5d4d07

Co-authored-by: FlorianPfaff <6773539+FlorianPfaff@users.noreply.github.com>

Author: Copilot

pyrecest/distributions/hypersphere_subset/complex_bingham_distribution.py

@@ -257,7 +257,7 @@ def _perturb_eigenvalues(eigenvalues):
 
         Mirrors MATLAB's makeSureEigenvaluesAreNotTooClose.
         """
-        lam = sort(eigenvalues)[::-1]
+        lam = sort(eigenvalues)[::-1].copy()
         diffs = diff(lam)  # non-positive for sorted-descending
         diffs = minimum(diffs, -0.01)  # enforce gap >= 0.01
         lam[1:] = lam[0] + cumsum(diffs)
@@ -314,7 +314,7 @@ def grad_log_c(lam):
             log_c0 = ComplexBinghamDistribution.log_norm(B_diag)
             grad = empty(d)
             for i in range(d):
-                lam_p = array(lam)
+                lam_p = lam.copy()
                 lam_p[i] += eps
                 log_cp = ComplexBinghamDistribution.log_norm(
                     diag(array(lam_p, dtype=complex128))

pyrecest/tests/distributions/test_complex_bingham_distribution.py

@@ -12,6 +12,7 @@
     log,
     mean,
     pi,
+    ones,
     random,
     real,
     sort,
@@ -115,7 +116,7 @@ def test_sample_unit_norm(self):
         random.seed(42)
         S = self.cB2.sample(100)
         norms = linalg.norm(S, axis=0)
-        npt.assert_allclose(norms, [1.0] * 100, atol=1e-12)
+        npt.assert_allclose(norms, ones(100), atol=1e-12)
 
     @unittest.skipIf(
         pyrecest.backend.__backend_name__ == "jax",  # pylint: disable=no-member
@@ -126,7 +127,7 @@ def test_sample_3d_unit_norm(self):
         random.seed(7)
         S = self.cB3.sample(50)
         norms = linalg.norm(S, axis=0)
-        npt.assert_allclose(norms, [1.0] * 50, atol=1e-12)
+        npt.assert_allclose(norms, ones(50), atol=1e-12)
 
     def test_log_norm_2d_analytic(self):
         a = 3.0