fix: better errors for sso login (#6113)

0xi4o · gemini-code-assist[bot] · yau-wd · web-flow · commit cb1e1e3363dd · 2026-04-03T16:20:31.000+05:30
* add: logs for sso

* revert: logs but throw better login error for sso

* Update packages/server/src/enterprise/sso/SSOBase.ts

Co-authored-by: gemini-code-assist[bot] &lt;176961590+gemini-code-assist[bot]@users.noreply.github.com&gt;

* fix: lint issues

* revert: error type check in sso login

---------

Co-authored-by: gemini-code-assist[bot] &lt;176961590+gemini-code-assist[bot]@users.noreply.github.com&gt;
Co-authored-by: yau-wd &lt;yau.ong@workday.com&gt;
diff --git a/packages/server/src/enterprise/sso/SSOBase.ts b/packages/server/src/enterprise/sso/SSOBase.ts
@@ -140,10 +140,8 @@ abstract class SSOBase {
             }
             return done(null, loggedInUser as Express.User, { message: 'Logged in Successfully' })
         } catch (error) {
-            return done(
-                { name: 'SSO_LOGIN_FAILED', message: ssoProviderName + ' Login failed! Please contact your administrator.' },
-                undefined
-            )
+            const message = error instanceof Error ? error.message : ssoProviderName + ' Login failed! Please contact your administrator.'
+            return done({ name: 'SSO_LOGIN_FAILED', message }, undefined)
         } finally {
             if (queryRunner && !queryRunner.isReleased) await queryRunner.release()
         }

Original file line number	Diff line number	Diff line change
`@@ -140,10 +140,8 @@ abstract class SSOBase {`
`140`	`140`	`}`
`141`	`141`	`return done(null, loggedInUser as Express.User, { message: 'Logged in Successfully' })`
`142`	`142`	`} catch (error) {`
`143`		`- return done(`
`144`		`- { name: 'SSO_LOGIN_FAILED', message: ssoProviderName + ' Login failed! Please contact your administrator.' },`
`145`		`- undefined`
`146`		`- )`
	`143`	`+ const message = error instanceof Error ? error.message : ssoProviderName + ' Login failed! Please contact your administrator.'`
	`144`	`+ return done({ name: 'SSO_LOGIN_FAILED', message }, undefined)`
`147`	`145`	`} finally {`
`148`	`146`	`if (queryRunner && !queryRunner.isReleased) await queryRunner.release()`
`149`	`147`	`}`