Merge pull request #59 from Flowpack/bugfix/dont-flush-empty-tags

daniellienert · web-flow · commit a4175c5b36aa · 2023-01-31T18:13:32.000+01:00
BUGFIX: Don't flush if tags is an empty array
diff --git a/Classes/Aspects/ContentCacheAspect.php b/Classes/Aspects/ContentCacheAspect.php
@@ -129,8 +129,10 @@ public function registerDisableContentCache(JoinPointInterface $joinPoint): void
     public function interceptContentCacheFlush(JoinPointInterface $joinPoint)
     {
         $object = $joinPoint->getProxy();
-
         $tags = array_keys(ObjectAccess::getProperty($object, 'tagsToFlush', true));
+        if ($tags === []) {
+          return;
+        }
 
         $this->varnishBanService->banByTags($tags);
     }

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,10 @@ public function registerDisableContentCache(JoinPointInterface $joinPoint): void`
`129`	`129`	`public function interceptContentCacheFlush(JoinPointInterface $joinPoint)`
`130`	`130`	`{`
`131`	`131`	`$object = $joinPoint->getProxy();`
`132`		`-`
`133`	`132`	`$tags = array_keys(ObjectAccess::getProperty($object, 'tagsToFlush', true));`
	`133`	`+ if ($tags === []) {`
	`134`	`+ return;`
	`135`	`+ }`
`134`	`136`
`135`	`137`	`$this->varnishBanService->banByTags($tags);`
`136`	`138`	`}`