Skip to content

Commit 5a891f3

Browse files
committed
test
1 parent 4ed3ee7 commit 5a891f3

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

ashes/Makefile

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ export GIT_COMMIT = $(shell git rev-parse --short HEAD)
99
export URL_PREFIX = /admin
1010
WEBPACK_PORT = 4001
1111

12+
.PHONY: notify
1213
notify:
1314
$(call header, $(MSG))
1415

@@ -26,17 +27,17 @@ CFLAGS = -c -g -D $(NODE_ENV)
2627
version = $(shell iojs -e "console.log(JSON.parse(require('fs').readFileSync('package.json')).version)")
2728

2829
.PHONY: docker
29-
docker: MSG=Dockerizing
30-
docker: notify
30+
docker:
31+
MSG=Dockerizing make notify
3132
docker build -t $(DOCKER_IMAGE) . --build-arg NPM_TOKEN=${NPM_TOKEN}
3233

3334
.PHONY: docker-run
3435
docker-run:
3536
docker run -it -p 4000:4000 ashes:latest
3637

3738
.PHONY: docker-push
38-
docker-push: MSG=Registering
39-
docker-push: notify
39+
docker-push:
40+
MSG=Registering make notify
4041
docker tag $(DOCKER_IMAGE) $(DOCKER_REPO)/$(DOCKER_IMAGE):$(DOCKER_TAG)
4142
docker push $(DOCKER_REPO)/$(DOCKER_IMAGE):$(DOCKER_TAG)
4243

@@ -54,11 +55,15 @@ clean:
5455

5556
# Do we actually need tests (not checks) on built aplication inside Ashes?
5657
.PHONY: test
57-
test: MSG=Testing
58-
test: notify
58+
test:
59+
MSG=Testing make notify
60+
61+
.PHONY: notify-check
62+
notify-check:
63+
MSG=Checking make notify
5964

6065
.PHONY: check t
61-
check t: flow lint mocha
66+
check t: notify-check flow lint mocha
6267

6368
.PHONY: mocha-spec
6469
mocha-spec:
@@ -98,6 +103,7 @@ fmt-%:
98103

99104
.PHONY: build-styleguide
100105
build-styleguide:
106+
MSG="Building Styleguilde" make notify
101107
styleguidist build --config styleguide/config.styleguide.js
102108

103109
.PHONY: styleguide sg
@@ -108,6 +114,7 @@ styleguide sg:
108114

109115
.PHONY: install i
110116
install i:
117+
MSG=Installing make notify
111118
rm -rf ./node_modules
112119
yarn cache clean
113120
yarn --pure-lockfile
@@ -132,6 +139,7 @@ dev d:
132139

133140
.PHONY: build-prod
134141
build-prod:
142+
MSG="Building Application" make notify
135143
NODE_ENV=production webpack --progress
136144

137145
.PHONY: prod p
@@ -141,5 +149,4 @@ prod p: clean build-prod
141149
# Buildkite ###
142150

143151
.PHONY: build
144-
build: MSG=Building
145-
build: notify clean install check build-styleguide build-prod
152+
build: clean install check build-styleguide build-prod

0 commit comments

Comments
 (0)