Add Cellular common AT command timeout config (#101)

* Update cellular library to MIT license

* Add cellular common AT command timeout config

* Add CELLULAR_COMMON_AT_COMMAND_TIMEOUT_MS config to set timeout value
  for Cellular_Common prefix APIs.
* Add CELLULAR_AT_COMMAND_RAW_TIMEOUT_MS config to set timeout value for
  Cellular_ATCommandRaw API.

* Update Cellular_CommonATCommandRaw unit test

Author: chinglee-iot

source/cellular_common_api.c

@@ -344,7 +344,9 @@ CellularError_t Cellular_CommonATCommandRaw( CellularHandle_t cellularHandle,
         atReqGetResult.dataLen = dataLen;
         atReqGetResult.respCallback = responseReceivedCallback;
 
-        pktStatus = _Cellular_AtcmdRequestWithCallback( pContext, atReqGetResult );
+        pktStatus = _Cellular_TimeoutAtcmdRequestWithCallback( pContext,
+                                                               atReqGetResult,
+                                                               CELLULAR_AT_COMMAND_RAW_TIMEOUT_MS );
         cellularStatus = _Cellular_TranslatePktStatus( pktStatus );
     }
 

source/include/cellular_config_defaults.h

@@ -361,6 +361,32 @@
     #define CELLULAR_CONFIG_STATIC_SOCKET_CONTEXT_ALLOCATION    ( 0 )
 #endif
 
+/**
+ * @brief Cellular common AT command timeout.<br>
+ *
+ * The timeout value for Cellular_Common prefix APIs. The timeout value should be
+ * set according to spec. It should be long enough for AT command used in cellular
+ * common APIs.
+ *
+ * <b>Possible values:</b>`Any positive integer`<br>
+ * <b>Default value (if undefined):</b> 5000
+ */
+#ifndef CELLULAR_COMMON_AT_COMMAND_TIMEOUT_MS
+    #define CELLULAR_COMMON_AT_COMMAND_TIMEOUT_MS    ( 5000U )
+#endif
+
+/**
+ * @brief Cellular AT command raw timeout.<br>
+ *
+ * The timeout value for Cellular_ATCommandRaw API.
+ *
+ * <b>Possible values:</b>`Any positive integer`<br>
+ * <b>Default value (if undefined):</b> 5000
+ */
+#ifndef CELLULAR_AT_COMMAND_RAW_TIMEOUT_MS
+    #define CELLULAR_AT_COMMAND_RAW_TIMEOUT_MS    ( 5000U )
+#endif
+
 /**
  * @brief Macro that is called in the cellular library for logging "Error" level
  * messages.

source/include/private/cellular_pkthandler_internal.h

@@ -44,7 +44,7 @@
 /*-----------------------------------------------------------*/
 
 /*  AT Command timeout for general AT commands. */
-#define PACKET_REQ_TIMEOUT_MS    ( 5000UL )
+#define PACKET_REQ_TIMEOUT_MS    CELLULAR_COMMON_AT_COMMAND_TIMEOUT_MS
 
 /*-----------------------------------------------------------*/
 

test/unit-test/cellular_common_api_utest.c

@@ -536,7 +536,7 @@ void test_Cellular_CommonATCommandRaw_AtCmd_Bad_Request( void )
     char pData[] = "Test Data";
 
     _Cellular_CheckLibraryStatus_IgnoreAndReturn( CELLULAR_SUCCESS );
-    _Cellular_AtcmdRequestWithCallback_IgnoreAndReturn( CELLULAR_PKT_STATUS_BAD_REQUEST );
+    _Cellular_TimeoutAtcmdRequestWithCallback_IgnoreAndReturn( CELLULAR_PKT_STATUS_BAD_REQUEST );
     _Cellular_TranslatePktStatus_IgnoreAndReturn( CELLULAR_INTERNAL_FAILURE );
 
     cellularStatus = Cellular_CommonATCommandRaw( &context, pPrefix, pData, 0, NULL, NULL, 0 );
@@ -557,7 +557,7 @@ void test_Cellular_CommonATCommandRaw_Happy_Path( void )
     char pData[] = "Test Data";
 
     _Cellular_CheckLibraryStatus_IgnoreAndReturn( CELLULAR_SUCCESS );
-    _Cellular_AtcmdRequestWithCallback_IgnoreAndReturn( CELLULAR_PKT_STATUS_OK );
+    _Cellular_TimeoutAtcmdRequestWithCallback_IgnoreAndReturn( CELLULAR_PKT_STATUS_OK );
     _Cellular_TranslatePktStatus_IgnoreAndReturn( CELLULAR_SUCCESS );
 
     cellularStatus = Cellular_CommonATCommandRaw( &context, pPrefix, pData, 0, NULL, NULL, 0 );