Skip to content

add support for Gogs repository#16

Open
slarosa wants to merge 1 commit into
FriendCode:masterfrom
slarosa:master
Open

add support for Gogs repository#16
slarosa wants to merge 1 commit into
FriendCode:masterfrom
slarosa:master

Conversation

@slarosa

@slarosa slarosa commented Nov 3, 2017

Copy link
Copy Markdown

No description provided.

@strk

strk commented Nov 5, 2017

Copy link
Copy Markdown

NOTE: Gogs (and Gitea) can also be installed in a subdirectory, so the url may look like: https://<domain>/<installpath>/<org>/<repo>

I dunno how giturlparse would deal with such URIs (it is server-configuration dependant)

@slarosa

slarosa commented Nov 5, 2017

Copy link
Copy Markdown
Author

I guess that we can add different patterns and formats more later, even if I think that <installpath> is part of host. So all is good here, for the moment. Waiting for testing!

@gene1wood

Copy link
Copy Markdown

@slarosa It looks like this repo hasn't been updated in about 3 years. @yakky has a fork called githubparse that has implemented a number of the PRs that are pending here on giturlparse.py and has activity from last year.

You might want to switch to his fork and propose your Gogs PR there.

@yakky

yakky commented Jan 20, 2018

Copy link
Copy Markdown
Contributor

Thanks @gene1wood
I am available to review this on my fork https://github.com/yakky/giturlparse

@slarosa

slarosa commented Feb 13, 2018

Copy link
Copy Markdown
Author

thanks @gene1wood, I will do a PR on @yakky's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants