if comment has a textual value, we dont serialize the <Attachment> element anymore. See DTD:

Author: mathielen

src/CXml/Jms/CXmlExclusionStrategy.php

@@ -18,17 +18,17 @@ public function shouldSkipClass(ClassMetadata $metadata, Context $context): bool
     public function shouldSkipProperty(PropertyMetadata $property, Context $context): bool
     {
         // Check if we are serializing to XML
-        if ($context->getFormat() !== 'xml') {
+        if ('xml' !== $context->getFormat()) {
             return false;
         }
 
-        if ($property->class === Comment::class) {
-            if ($property->name === 'attachment') {
+        if (Comment::class === $property->class) {
+            if ('attachment' === $property->name) {
                 /** @var Comment $object */
                 $object = $context->getObject();
 
-                //if comment has a textual value, we dont serialize the <Attachment> element anymore. See DTD:
-                //<!ELEMENT Comments ( #PCDATA | Attachment )* >
+                // if comment has a textual value, we dont serialize the <Attachment> element anymore. See DTD:
+                // <!ELEMENT Comments ( #PCDATA | Attachment )* >
                 if (isset($object->value)) {
                     return true;
                 }

src/CXml/Serializer.php

@@ -56,7 +56,7 @@ public static function create(): self
             )
             ->setSerializationContextFactory(function() {
                 return SerializationContext::create()
-                        ->addExclusionStrategy(new CXmlExclusionStrategy());
+                    ->addExclusionStrategy(new CXmlExclusionStrategy());
             })
             ->build();
 

tests/CXmlTest/Model/OrderRequestTest.php

@@ -51,7 +51,7 @@ protected function setUp(): void
 
     public function testReference(): void
     {
-        //test whether deserialize/serialize of the reference file works
+        // test whether deserialize/serialize of the reference file works
         $xml = file_get_contents(__DIR__ . '/../../metadata/cxml/samples/OrderRequest.xml');
         $cxml = Serializer::create()->deserialize($xml);
         Serializer::create()->serialize($cxml);
@@ -182,7 +182,7 @@ public function testMinimumExample(): void
             ),
             new DateTime('2020-02-28'),
         );
-        $item->addComment(new Comment('Test comment', 'test', '')); //, 'delivery-note.pdf'));
+        $item->addComment(new Comment('Test comment', 'test', ''));
 
         $orderRequest->addItem($item);