add missing pclose()

Signed-off-by: Michel-FK <michel.stempin@funkey-project.com>

Author: Michel-FK

src/funkeymenu.cpp

@@ -411,6 +411,7 @@ void FunkeyMenu::init_menu_system_values(){
 		volume_percentage = 50; ///wrong value: setting default to 50
 	}
 	else{
+		pclose(fp);
 		fgets(res, sizeof(res)-1, fp);
 
 		/// Check if Volume is a number (at least the first char)
@@ -431,6 +432,7 @@ void FunkeyMenu::init_menu_system_values(){
 		brightness_percentage = 50; ///wrong value: setting default to 50
 	}
 	else{
+		pclose(fp);
 		fgets(res, sizeof(res)-1, fp);
 
 		/// Check if brightness is a number (at least the first char)
@@ -828,6 +830,8 @@ int FunkeyMenu::launch( )
 							fp = popen(shell_cmd, "r");
 							if (fp == NULL) {
 								MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+							} else {
+								pclose(fp);
 							}
 
 							/// ------ Refresh screen ------
@@ -844,6 +848,8 @@ int FunkeyMenu::launch( )
 							fp = popen(shell_cmd, "r");
 							if (fp == NULL) {
 								MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+							} else {
+								pclose(fp);
 							}
 							/// ------ Refresh screen ------
 							screen_refresh = 1;
@@ -889,6 +895,8 @@ int FunkeyMenu::launch( )
 							fp = popen(shell_cmd, "r");
 							if (fp == NULL) {
 								MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+							} else {
+								pclose(fp);
 							}
 							/// ------ Refresh screen ------
 							screen_refresh = 1;
@@ -904,6 +912,8 @@ int FunkeyMenu::launch( )
 							fp = popen(shell_cmd, "r");
 							if (fp == NULL) {
 								MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+							} else {
+								pclose(fp);
 							}
 							/// ------ Refresh screen ------
 							screen_refresh = 1;
@@ -982,6 +992,7 @@ int FunkeyMenu::launch( )
 									MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
 								}
 								else{
+									pclose(fp);
 									usb_sharing = !usb_sharing;
 								}*/
 
@@ -1053,6 +1064,8 @@ int FunkeyMenu::launch( )
 								fp = popen(shell_cmd, "r");
 								if (fp == NULL) {
 									MENU_ERROR_PRINTF("Failed to run command %s\n", shell_cmd);
+								} else {
+									pclose(fp);
 								}
 
 								return MENU_RETURN_EXIT;

src/gmenu2x.cpp

@@ -126,14 +126,19 @@ static void quit_all(int err) {
 /* Quick save and turn off the console */
 static void quick_poweroff()
 {
-	/* Send command to cancel any previously scheduled powerdown */
-    if (popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r") == NULL)
+    FILE *fp;
+
+    /* Send command to cancel any previously scheduled powerdown */
+    fp = popen(SHELL_CMD_CANCEL_SCHED_POWERDOWN, "r");
+    if (fp == NULL)
     {
         /* Countdown is still ticking, so better do nothing
 		   than start writing and get interrupted!
 		*/
 	    printf("Failed to cancel scheduled shutdown\n");
 		exit(0);
+    } else {
+        pclose(fp);
     }
 
     /* Perform Instant Play save and shutdown */
@@ -173,15 +178,20 @@ static void set_handler(int signal, void (*handler)(int))
 }
 
 int main(int /*argc*/, char * /*argv*/[]) {
+	FILE *fp;
+
 	INFO("---- GMenu2X starting ----\n");
 
 	set_handler(SIGINT, &quit_all);
 	set_handler(SIGSEGV, &quit_all);
 	set_handler(SIGTERM, &quit_all);
 	set_handler(SIGUSR1, &handle_sigusr1);
 
-    /* Stop Ampli */
-    popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+	/* Stop Ampli */
+	fp = popen(SHELL_CMD_TURN_AMPLI_OFF, "r");
+	if (fp != NULL) {
+		pclose(fp);
+	}
 
 	char *home = getenv("HOME");
 	if (home == NULL) {

src/launcher.cpp

@@ -32,9 +32,13 @@ Launcher::Launcher(vector<string> && commandLine, bool consoleApp)
 
 void Launcher::exec()
 {
+	FILE *fp;
 
-    /* Start audio amp */
-    popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+	/* Start audio amp */
+	fp = popen(SHELL_CMD_TURN_AMPLI_ON, "r");
+	if (fp != NULL) {
+		pclose(fp);
+	}
 
 	if (consoleApp) {
 #ifdef BIND_CONSOLE