Make destructors virtual where needed

janisozaur · web-flow · commit 73ad8952659c · 2018-10-27T23:31:45.000+02:00
A class with virtual methods should have virtual destructor
diff --git a/include/wrappers/descriptor_set.h b/include/wrappers/descriptor_set.h
@@ -262,7 +262,7 @@ namespace Anvil
              *
              *  Releases the embedded image view instance.
              **/
-            ~ImageBindingElement();
+            virtual ~ImageBindingElement();
 
             /* Returns Vulkan descriptor type for this structure */
             virtual Anvil::DescriptorType get_type() const = 0;
@@ -385,7 +385,7 @@ namespace Anvil
              *
              *  Releases the embedded buffer view instance.
              **/
-            ~TexelBufferBindingElement();
+            virtual ~TexelBufferBindingElement();
 
             /** Copy assignment operator.
              *
@@ -906,4 +906,4 @@ namespace Anvil
     };
 };
 
-#endif /* WRAPPERS_DESCRIPTOR_SET_H */
+#endif /* WRAPPERS_DESCRIPTOR_SET_H */

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ namespace Anvil`
`262`	`262`	`*`
`263`	`263`	`* Releases the embedded image view instance.`
`264`	`264`	`**/`
`265`		`- ~ImageBindingElement();`
	`265`	`+ virtual ~ImageBindingElement();`
`266`	`266`
`267`	`267`	`/* Returns Vulkan descriptor type for this structure */`
`268`	`268`	`virtual Anvil::DescriptorType get_type() const = 0;`
`@@ -385,7 +385,7 @@ namespace Anvil`
`385`	`385`	`*`
`386`	`386`	`* Releases the embedded buffer view instance.`
`387`	`387`	`**/`
`388`		`- ~TexelBufferBindingElement();`
	`388`	`+ virtual ~TexelBufferBindingElement();`
`389`	`389`
`390`	`390`	`/** Copy assignment operator.`
`391`	`391`	`*`
`@@ -906,4 +906,4 @@ namespace Anvil`
`906`	`906`	`};`
`907`	`907`	`};`
`908`	`908`
`909`		`-#endif /* WRAPPERS_DESCRIPTOR_SET_H */`
	`909`	`+#endif /* WRAPPERS_DESCRIPTOR_SET_H */`