Skip to content
This repository was archived by the owner on Apr 30, 2020. It is now read-only.

Commit f7fadbe

Browse files
committed
CODEXL-3087
Last CmdBuffer information always shown wrong (Execution time copied from prev call, # of commands shown zero etc)
1 parent 92b04ae commit f7fadbe

2 files changed

Lines changed: 506 additions & 486 deletions

File tree

CodeXL/Components/GpuProfiling/AMDTGpuProfiling/gpTraceSummaryTable.cpp

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11

2-
//=====================================================================
2+
#include <qtIgnoreCompilerWarnings.h>
33

4-
//=====================================================================
4+
// Infra:
5+
#include <AMDTApplicationComponents/Include/acColours.h>
6+
#include <AMDTApplicationComponents/Include/acFunctions.h>
7+
#include <AMDTApplicationComponents/Include/Timeline/acTimelineItem.h>
8+
#include <AMDTApplicationComponents/Include/Timeline/acTimelineBranch.h>
9+
10+
// AMDTApplicationFramework:
11+
#include <AMDTApplicationFramework/Include/afAppStringConstants.h>
12+
#include <AMDTApplicationFramework/Include/afProgressBarWrapper.h>
513

14+
// Local:
615
#include <AMDTGpuProfiling/gpTraceSummaryTable.h>
716
#include <AMDTGpuProfiling/gpTraceSummaryWidget.h>
817
#include <AMDTGpuProfiling/gpTraceDataContainer.h>
918
#include <AMDTGpuProfiling/APIColorMap.h>
1019
#include <AMDTGpuProfiling/gpTraceView.h>
1120

12-
#include <AMDTApplicationComponents/Include/acColours.h>
13-
#include <AMDTApplicationComponents/Include/acFunctions.h>
14-
#include <AMDTApplicationFramework/Include/afProgressBarWrapper.h>
15-
#include <AMDTApplicationComponents/Include/Timeline/acTimelineItem.h>
16-
#include <AMDTApplicationComponents/Include/Timeline/acTimelineBranch.h>
17-
#include <AMDTApplicationFramework/Include/afAppStringConstants.h>
1821

1922
const int SUMMARY_INFO_ARRAY_SIZE = 500; // 130 DX12 call types, X Vulcan call types...
2023

@@ -802,10 +805,20 @@ void gpCommandListSummaryTable::AddSummaryRow(int rowIndex, APISummaryInfo* pInf
802805
case COLUMN_NUM_OF_COMMANDS:
803806
{
804807
pItem = new QTableWidgetItem();
808+
809+
// For number of commands, set both text and value, to make sure that the column is sortable, and enable
810+
// display of N/A string for 0 calls
811+
setItem(rowIndex, i, pItem);
812+
805813
if (pInfo->m_numCalls == 0)
806814
{
807815
shouldSetCmdBufferTooltip = true;
808816
}
817+
QVariant dataVariant;
818+
dataVariant.setValue(rowStrings[i].toDouble());
819+
pItem->setData(Qt::EditRole, dataVariant);
820+
pItem->setData(Qt::DisplayRole, rowStrings[i]);
821+
shouldSetValue = false;
809822
}
810823
break;
811824
}

0 commit comments

Comments
 (0)