fix: check response status before parsing JSON in init request

Gogoshika-ga · Gogoshika-ga · commit 24090ca451f0 · 2026-04-02T10:20:00.000+03:00
diff --git a/source/gameanalytics/GAHTTPApi.cpp b/source/gameanalytics/GAHTTPApi.cpp
@@ -98,8 +98,6 @@ namespace gameanalytics
                 // process the response
                 logging::GALogger::d("init request content: %.*s, json: %s", (int)content.size(), content.data(), jsonString.c_str());
 
-                json requestJsonDict = json::parse(content);
-
                 EGAHTTPApiResponse requestResponseEnum = processRequestResponse(response, "Init");
 
                 // if not 200 result
@@ -110,6 +108,7 @@ namespace gameanalytics
                     return requestResponseEnum;
                 }
 
+                json requestJsonDict = json::parse(content);
                 if (requestJsonDict.is_null())
                 {
                     logging::GALogger::d("Failed Init Call. Json decoding failed");

Original file line number	Diff line number	Diff line change
`@@ -98,8 +98,6 @@ namespace gameanalytics`
`98`	`98`	`// process the response`
`99`	`99`	`logging::GALogger::d("init request content: %.*s, json: %s", (int)content.size(), content.data(), jsonString.c_str());`
`100`	`100`
`101`		`- json requestJsonDict = json::parse(content);`
`102`		`-`
`103`	`101`	`EGAHTTPApiResponse requestResponseEnum = processRequestResponse(response, "Init");`
`104`	`102`
`105`	`103`	`// if not 200 result`
`@@ -110,6 +108,7 @@ namespace gameanalytics`
`110`	`108`	`return requestResponseEnum;`
`111`	`109`	`}`
`112`	`110`
	`111`	`+ json requestJsonDict = json::parse(content);`
`113`	`112`	`if (requestJsonDict.is_null())`
`114`	`113`	`{`
`115`	`114`	`logging::GALogger::d("Failed Init Call. Json decoding failed");`