handle code 204 as success

Author: dorin-ga

source/gameanalytics/GAHTTPApi.cpp

@@ -199,7 +199,7 @@ namespace gameanalytics
                 res = curl_easy_perform(curl);
                 if (res != CURLE_OK)
                 {
-                    logging::GALogger::d(curl_easy_strerror(res));
+                    logging::GALogger::d("%s", curl_easy_strerror(res));
                     return NoResponse;
                 }
 
@@ -211,13 +211,21 @@ namespace gameanalytics
 
                 EGAHTTPApiResponse requestResponseEnum = processRequestResponse(response_code, s.packet.data(), "Events");
 
+                const bool isValidResponse = 
+                    requestResponseEnum == Ok || requestResponseEnum == Created || requestResponseEnum == NoContent;
+
                 // if not 200 result
-                if (requestResponseEnum != Ok && requestResponseEnum != Created && requestResponseEnum != BadRequest)
+                if (!isValidResponse && requestResponseEnum != BadRequest)
                 {
                     logging::GALogger::d("Failed Events Call. URL: %s, JSONString: %s, Authorization: %s", url.c_str(), jsonString.c_str(), authorization.data());
                     return requestResponseEnum;
                 }
 
+                if(requestResponseEnum == NoContent)
+                {
+                    return requestResponseEnum;
+                }
+
                 // decode JSON
                 json requestJsonDict = json::parse(s.toString());
                 if (requestJsonDict.is_null())
@@ -438,6 +446,10 @@ namespace gameanalytics
             {
                 return Created;
             }
+            if(statusCode == 204)
+            {
+                return NoContent;
+            }
 
             // 401 can return 0 status
             if (statusCode == 0 || statusCode == 401)