Linting

Author: GeEom

src/ops/circular.rs

@@ -4,7 +4,7 @@ use crate::bounded::{NonNegative, UnitInterval};
 use crate::error::{Error, Result};
 use crate::kernel::circular_vectoring;
 use crate::ops::algebraic::sqrt_nonneg;
-use crate::tables::chebyshev::{horner, COS_Q_HI, COS_Q_LO, SIN_P_HI, SIN_P_LO};
+use crate::tables::chebyshev::{COS_Q_HI, COS_Q_LO, SIN_P_HI, SIN_P_LO, horner};
 use crate::traits::CordicNumber;
 
 /// Sine and cosine. More efficient than separate calls. Accepts any angle.
@@ -68,17 +68,13 @@ pub fn sin_cos<T: CordicNumber>(angle: T) -> (T, T) {
     let (sp_val, cp_val) = if T::frac_bits() >= 24 {
         // High precision: degree 15 sin, degree 14 cos
         let sp = horner(&SIN_P_HI, u);
-        let sin_approx = poly_arg.saturating_add(
-            poly_arg.saturating_mul(u).saturating_mul(sp),
-        );
+        let sin_approx = poly_arg.saturating_add(poly_arg.saturating_mul(u).saturating_mul(sp));
         let cp = horner(&COS_Q_HI, u);
         (sin_approx, one.saturating_add(u.saturating_mul(cp)))
     } else {
         // Low precision: degree 9 sin, degree 8 cos
         let sp = horner(&SIN_P_LO, u);
-        let sin_approx = poly_arg.saturating_add(
-            poly_arg.saturating_mul(u).saturating_mul(sp),
-        );
+        let sin_approx = poly_arg.saturating_add(poly_arg.saturating_mul(u).saturating_mul(sp));
         let cp = horner(&COS_Q_LO, u);
         (sin_approx, one.saturating_add(u.saturating_mul(cp)))
     };

src/tables/chebyshev.rs

@@ -84,4 +84,3 @@ pub const COS_Q_HI: [i64; 7] = [
      0x0555_5555_5555_5435,  // +4.167e-02
     -0x3FFF_FFFF_FFFF_FFFE,  // -5.000e-01
 ];
-

tests/unit/tables/chebyshev.rs

@@ -60,10 +60,7 @@ mod tests {
         ] {
             for (i, &bits) in table.iter().enumerate() {
                 let val = i1f63_to_f64(bits).abs();
-                assert!(
-                    val < 1.0,
-                    "{name}[{i}] = {val}, exceeds I1F63 range"
-                );
+                assert!(val < 1.0, "{name}[{i}] = {val}, exceeds I1F63 range");
             }
         }
     }

tests/unit/traits.rs

@@ -82,6 +82,22 @@ mod tests {
         assert_eq!(I48F16::frac_bits(), 16);
     }
 
+    #[test]
+    fn div_overflow_saturates_to_min() {
+        // Dividing a negative number by zero should saturate to MIN
+        // (signs disagree: negative / "positive zero").
+        let neg = I16F16::from_num(-1);
+        let zero = I16F16::ZERO;
+        assert_eq!(neg.div(zero), I16F16::MIN);
+    }
+
+    #[test]
+    fn div_by_zero_positive_saturates_to_max() {
+        let pos = I16F16::from_num(1);
+        let zero = I16F16::ZERO;
+        assert_eq!(pos.div(zero), I16F16::MAX);
+    }
+
     #[test]
     fn frac_pi_4_values() {
         // Test the frac_pi_4() default implementation