fix: hasSendableData logic for offline storage enabled (#1692)

Change logic for the `hasSendableData` when the composition exists for
except the quoted message when offline storage is enabled.

Author: khushal87

src/messageComposer/messageComposer.ts

@@ -327,7 +327,12 @@ export class MessageComposer extends WithSubscriptions {
   get hasSendableData() {
     // If the offline mode is enabled, we allow sending a message if the composition is not empty.
     if (this.client.offlineDb) {
-      return !this.compositionIsEmpty;
+      return (
+        !this.textComposer.textIsEmpty ||
+        !!this.attachmentManager.attachments.length ||
+        !!this.pollId ||
+        !!this.locationComposer.validLocation
+      );
     }
     return !!(
       (!this.attachmentManager.uploadsInProgressCount &&

test/unit/MessageComposer/messageComposer.test.ts

@@ -627,26 +627,36 @@ describe('MessageComposer', () => {
   });
 
   describe('offlineDB enabled', () => {
-    it('hasSendableData should return false if the composition is empty', () => {
-      const { messageComposer } = offlineModeMessageComposerSetup();
+    it('hasSendableData should return true if the composition is not empty', () => {
+      const { messageComposer } = offlineModeMessageComposerSetup({
+        composition: {
+          id: 'test-message-id',
+          type: 'regular',
+          text: 'Hello',
+        },
+      });
 
-      const spyCompositionIsEmpty = vi
-        .spyOn(messageComposer, 'compositionIsEmpty', 'get')
-        .mockReturnValue(true);
+      expect(messageComposer.hasSendableData).toBe(true);
+    });
 
-      expect(messageComposer.hasSendableData).toBe(false);
-      spyCompositionIsEmpty.mockRestore();
+    it('hasSendableData should return true if the composition is not empty with attachments', () => {
+      const { messageComposer } = offlineModeMessageComposerSetup({
+        composition: {
+          id: 'test-message-id',
+          type: 'regular',
+          attachments: [
+            { type: 'x', localMetadata: { id: 'x,', uploadState: 'finished', file: {} } },
+          ],
+        },
+      });
+
+      expect(messageComposer.hasSendableData).toBe(true);
     });
 
-    it('hasSendableData should return true if the composition is not empty', () => {
+    it('hasSendableData should return false if the composition is empty', () => {
       const { messageComposer } = offlineModeMessageComposerSetup();
 
-      const spyCompositionIsEmpty = vi
-        .spyOn(messageComposer, 'compositionIsEmpty', 'get')
-        .mockReturnValue(false);
-
-      expect(messageComposer.hasSendableData).toBe(true);
-      spyCompositionIsEmpty.mockRestore();
+      expect(messageComposer.hasSendableData).toBe(false);
     });
   });