Make domain push dupe checks debug-only and use push_unchecked in the Morph node

Author: Keavon

node-graph/libraries/vector-types/src/vector/vector_attributes.rs

@@ -129,14 +129,16 @@ impl PointDomain {
 	}
 
 	pub fn push(&mut self, id: PointId, position: DVec2) {
+		#[cfg(debug_assertions)]
 		if self.id.contains(&id) {
+			warn!("Tried to push a duplicate point to a point domain");
 			return;
 		}
 
-		self.id.push(id);
-		self.position.push(position);
+		self.push_unchecked(id, position);
 	}
 
+	#[inline(always)]
 	pub fn push_unchecked(&mut self, id: PointId, position: DVec2) {
 		self.id.push(id);
 		self.position.push(position);
@@ -316,9 +318,15 @@ impl SegmentDomain {
 	pub fn push(&mut self, id: SegmentId, start: usize, end: usize, handles: BezierHandles, stroke: StrokeId) {
 		#[cfg(debug_assertions)]
 		if self.id.contains(&id) {
-			warn!("Tried to push an existing point to a point domain");
+			warn!("Tried to push a duplicate segment to a segment domain");
+			return;
 		}
 
+		self.push_unchecked(id, start, end, handles, stroke);
+	}
+
+	#[inline(always)]
+	pub fn push_unchecked(&mut self, id: SegmentId, start: usize, end: usize, handles: BezierHandles, stroke: StrokeId) {
 		self.id.push(id);
 		self.start_point.push(start);
 		self.end_point.push(end);
@@ -618,10 +626,17 @@ impl RegionDomain {
 	}
 
 	pub fn push(&mut self, id: RegionId, segment_range: std::ops::RangeInclusive<SegmentId>, fill: FillId) {
+		#[cfg(debug_assertions)]
 		if self.id.contains(&id) {
-			warn!("Duplicate region");
+			warn!("Tried to push a duplicate region to a region domain");
 			return;
 		}
+
+		self.push_unchecked(id, segment_range, fill);
+	}
+
+	#[inline(always)]
+	pub fn push_unchecked(&mut self, id: RegionId, segment_range: std::ops::RangeInclusive<SegmentId>, fill: FillId) {
 		self.id.push(id);
 		self.segment_range.push(segment_range);
 		self.fill.push(fill);

node-graph/nodes/vector/src/vector_nodes.rs

@@ -2045,18 +2045,18 @@ async fn morph<I: IntoGraphicTable + 'n + Send + Clone>(
 		let Some(first) = manips.first() else { return };
 
 		let first_point_index = vector.point_domain.ids().len();
-		vector.point_domain.push(point_id.next_id(), first.anchor);
+		vector.point_domain.push_unchecked(point_id.next_id(), first.anchor);
 		let mut prev_point_index = first_point_index;
 		let mut first_segment_id = None;
 
 		for manip_window in manips.windows(2) {
 			let point_index = vector.point_domain.ids().len();
-			vector.point_domain.push(point_id.next_id(), manip_window[1].anchor);
+			vector.point_domain.push_unchecked(point_id.next_id(), manip_window[1].anchor);
 
 			let handles = handles_from_manips(manip_window[0].out_handle, manip_window[1].in_handle);
 			let seg_id = segment_id.next_id();
 			first_segment_id.get_or_insert(seg_id);
-			vector.segment_domain.push(seg_id, prev_point_index, point_index, handles, StrokeId::ZERO);
+			vector.segment_domain.push_unchecked(seg_id, prev_point_index, point_index, handles, StrokeId::ZERO);
 
 			prev_point_index = point_index;
 		}
@@ -2065,10 +2065,10 @@ async fn morph<I: IntoGraphicTable + 'n + Send + Clone>(
 			let handles = handles_from_manips(manips.last().unwrap().out_handle, manips[0].in_handle);
 			let closing_seg_id = segment_id.next_id();
 			first_segment_id.get_or_insert(closing_seg_id);
-			vector.segment_domain.push(closing_seg_id, prev_point_index, first_point_index, handles, StrokeId::ZERO);
+			vector.segment_domain.push_unchecked(closing_seg_id, prev_point_index, first_point_index, handles, StrokeId::ZERO);
 
 			let region_id = vector.region_domain.next_id();
-			vector.region_domain.push(region_id, first_segment_id.unwrap()..=closing_seg_id, FillId::ZERO);
+			vector.region_domain.push_unchecked(region_id, first_segment_id.unwrap()..=closing_seg_id, FillId::ZERO);
 		}
 	}