Skip to content

Commit 0b3c0b9

Browse files
committed
fix framed top border
1 parent 357e25f commit 0b3c0b9

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

docs/void/plan-constraints-v2.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ Move sketch solving to a clean planegcs-first architecture, remove dual-solver b
5353
3. Add deterministic logs for tangent constraint path selection.
5454

5555
Exit Criteria:
56+
5657
1. We can observe when and why fallback is invoked.
5758

5859
## Phase 2: Temporary Drag Constraints
@@ -62,6 +63,7 @@ Exit Criteria:
6263
3. Keep fallback only if planegcs solve fails or returns non-converged status.
6364

6465
Exit Criteria:
66+
6567
1. Drag no longer “snaps back” from dual-pass disagreement.
6668
2. Solver path during normal drag is planegcs-only.
6769

@@ -73,6 +75,7 @@ Exit Criteria:
7375
3. Keep old tangent fallback path behind a temporary feature flag for rollback.
7476

7577
Exit Criteria:
78+
7679
1. Tangent drag corner cases no longer require tangent-specific fallback aggressiveness.
7780
2. Shared-endpoint tangent cases are stable under repeated edits/drag.
7881

@@ -83,6 +86,7 @@ Exit Criteria:
8386
3. Keep compatibility switch (`constraints_v2_force_fallback`) for emergency rollback.
8487

8588
Exit Criteria:
89+
8690
1. Single primary solver behavior in normal operation.
8791
2. Fewer constraint jitter/regressions from solver disagreement.
8892

@@ -93,6 +97,7 @@ Exit Criteria:
9397
3. Document canonical constraint mapping table and temporary-constraint rules.
9498

9599
Exit Criteria:
100+
96101
1. Constraint code paths are materially simpler and easier to reason about.
97102

98103
## Proposed Code Touchpoints

src/kiri/app/init/sync.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@ export async function init_sync() {
120120
setup_keybd_nav();
121121

122122
// show topline separator when iframed
123-
try { if (WIN.self !== WIN.top) $('top-sep').style.display = 'flex' } catch (e) { console.log(e) }
123+
if (WIN.self !== WIN.top) {
124+
$('menubar').classList.add('top');
125+
}
124126

125127
// warn users they are running a beta release
126128
if (beta && beta > 0 && sdb.kiri_beta != beta) {

web/kiri/index.css

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -905,14 +905,6 @@ details[open] summary::after {
905905
.widopt button.disabled {
906906
background-color: var(--blue-3);
907907
}
908-
#top-sep {
909-
display: none;
910-
z-index: 14;
911-
height: 1px;
912-
min-height: 1px;
913-
max-height: 1px;
914-
background-image: var(--gradbar);
915-
}
916908
.line-sep2 {
917909
z-index: 14;
918910
height: 1px;

web/kiri/index.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@
4545
<!-- hide page contents and provide loading message during initialization -->
4646
<div id="curtain" class="j-center a-center"><img id="loading">Kiri:Moto is Loading</div>
4747

48-
<!-- when running iframed, provide a separator between the menu bar and enclosing page -->
49-
<div id="top-sep" class="el-app-hide"></div>
50-
5148
<!-- top menu bar -->
5249
<div id="menubar" class="f-row"></div>
5350

web/moto/menubar.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@
88
border-bottom: 1px solid var(--border-gray);
99
}
1010

11+
#menubar.top{
12+
border-top: 1px solid var(--border-gray);
13+
}
14+
1115
.menubar-separator {
1216
align-self: stretch;
1317
align-items: center;

0 commit comments

Comments
 (0)