cppcheck

Author: Grok Compression

src/lib/codec/apps/GrkCompress.cpp

@@ -617,8 +617,6 @@ static void setHT(grk_cparameters* parameters, bool hasCompressionRatios, bool h
   }
 }
 
-
-
 uint8_t charToUint8(char c)
 {
   switch(c)

src/lib/core/t2/T2Decompress.h

@@ -34,7 +34,7 @@ struct T2Decompress
    * @brief Constructs a T2Decompress object
    * @param tileProc @ref TileProcesor
    */
-  T2Decompress(ITileProcessor* tileProc);
+  explicit T2Decompress(ITileProcessor* tileProc);
 
   /**
    * @brief Destroys a T2Decompress object

src/lib/core/tile_processor/TileProcessor.cpp

@@ -1306,10 +1306,6 @@ Rect32 TileProcessor::getUnreducedTileWindow(void)
   return unreducedImageWindow_.clip(tile_);
 }
 
-uint64_t TileProcessor::getNumReadDataPackets(void)
-{
-  return numReadDataPackets_;
-}
 void TileProcessor::incNumReadDataPackets(void)
 {
   numReadDataPackets_++;

src/lib/core/tile_processor/TileProcessor.h

@@ -47,7 +47,7 @@ struct TileProcessor : virtual public ITileProcessor
   /**
    * @brief Destroys a TileProcessor
    */
-  virtual ~TileProcessor();
+  virtual ~TileProcessor() override;
 
   void setProcessors(MarkerParser* parser) override;
 
@@ -184,7 +184,7 @@ struct TileProcessor : virtual public ITileProcessor
    *
    * @return Tile*
    */
-  Tile* getTile(void);
+  Tile* getTile(void) override;
 
   grk_progression_state getProgressionState() override;
 
@@ -437,13 +437,6 @@ struct TileProcessor : virtual public ITileProcessor
    */
   bool createDecompressTileComponentWindows(void);
 
-  /**
-   * @brief Get the Num Read Data Packets object
-   *
-   * @return number of read data packets
-   */
-  uint64_t getNumReadDataPackets(void);
-
   /**
    * @brief @ref MarkerParser
    *

src/lib/core/util/GrkImage.cpp

@@ -831,26 +831,6 @@ void GrkImage::filterComponents(const std::vector<uint16_t>& compsToKeep)
   decompress_num_comps = newNumComps;
 }
 
-GrkImage* GrkImage::duplicate(void) const
-{
-  auto destImage = new GrkImage();
-  copyHeaderTo(destImage);
-  for(uint16_t compno = 0; compno < numcomps; ++compno)
-  {
-    auto compDest = destImage->comps + compno;
-    auto compSrc = comps + compno;
-    GrkImage::allocData(compDest);
-    assert(compSrc->stride <= compDest->stride);
-    compDest->stride = compSrc->stride;
-    assert(compSrc->w == compDest->w);
-    std::memcpy(compDest->data, compSrc->data,
-                (size_t)compSrc->stride * compSrc->h * sizeOfDataType(compSrc->data_type));
-    assert(componentsEqual(compSrc, compDest, true));
-  }
-
-  return destImage;
-}
-
 /**
  * Create new image and transfer tile buffer data
  *

src/lib/core/util/GrkImage.h

@@ -112,7 +112,6 @@ class GrkImage : public grk_image
   void transferDataTo(GrkImage* dest);
   void filterComponents(const std::vector<uint16_t>& compsToKeep);
   GrkImage* extractFrom(const Tile* tile_src) const;
-  GrkImage* duplicate(void) const;
   bool composite(const GrkImage* src);
   bool greyToRGB(void);
   bool applyColourManagement(void);