Code improvements (#85)

* Code analysis improvements:

 - Add cppcheck wrapper script: `./scripts/cppcheck`
 - Address cppcheck errors
 - Fix warnings in project

* Fix more cppcheck warnings. Add unit test for SER color conversion

* More cppcheck issues addressed

#skip_ci

Author: GuLinux

scripts/cppcheck

@@ -0,0 +1,29 @@
+#!/bin/bash
+PROJECT_DIR="$( cd "$( dirname "$0" )/.."; pwd )"
+BUILD_DIR="${BUILD_DIR:-$PROJECT_DIR/build}"
+mkdir -p "$BUILD_DIR"
+
+cppcheck \
+    --cppcheck-build-dir="${BUILD_DIR}" \
+    --enable=all \
+    -i src/drivers/zwo_asi/ASI_Linux_Mac_v1.14.0425 \
+    -i src/drivers/zwo_asi/ASI_Windows_v1.14.0425 \
+    -i src/drivers/qhy/QHY_Linux_armv7_v5.0.7 \
+    -i src/drivers/qhy/QHY_Linux_x86_64_v5.0.7 \
+    -i src/drivers/qhy/QHY_Mac_x86_64_v5.0.7 \
+    -i src/drivers/qhy/QHY_Windows_v5.0.7 \
+    -DQ_IMPORT_PLUGIN \
+    -DQ_DECLARE_METATYPE \
+    --xml \
+    -I "${BUILD_DIR}/GuLinux-Commons" \
+    -I "${BUILD_DIR}/GuLinux-Commons/c++" \
+    -I "${BUILD_DIR}/GuLinux-Commons/Qt" \
+    "$@" \
+    src 2> "$BUILD_DIR/cppcheck.xml"
+if [ -r "$BUILD_DIR/cppcheck.xml" ]; then
+    cppcheck-htmlreport \
+        --title="PlanetaryImager cppcheck report" \
+        --file="$BUILD_DIR/cppcheck.xml" \
+        --report-dir="$BUILD_DIR/cppcheck" \
+        --source-dir="$PROJECT_DIR"
+fi

src/commons/commandline.cpp

@@ -31,7 +31,6 @@ using namespace std::placeholders;
 
 DPTR_IMPL(CommandLine) {
   QCoreApplication &app;
-  CommandLine *q;
   QCommandLineParser parser;
   void loggingOptions();
 };
@@ -46,7 +45,7 @@ void CommandLine::Private::loggingOptions()
 }
 
 
-CommandLine::CommandLine(QCoreApplication& app) : dptr(app, this)
+CommandLine::CommandLine(QCoreApplication& app) : dptr(app)
 {
   d->parser.addHelpOption();
   d->parser.addVersionOption();

src/commons/commandline.h

@@ -26,7 +26,7 @@ class QCoreApplication;
 class CommandLine
 {
 public:
-  CommandLine(QCoreApplication &app);
+  explicit CommandLine(QCoreApplication &app);
   ~CommandLine();
   CommandLine &backend();
   CommandLine &daemon(const QString &listenAddress = "0.0.0.0");

src/commons/configuration.cpp

@@ -76,7 +76,7 @@ template<typename T> void Configuration::Private::set(const QString& key, const
 {
   settings->setValue(key, value);
   values_cache[key] = value;
-  emit q->settings_changed();
+  emit this->q->settings_changed();
 }
 
 
@@ -295,8 +295,3 @@ void Configuration::Preset::save(const QVariantMap& presets)
   }
   file.write(QJsonDocument::fromVariant(presets).toJson());
 }
-
- 
-
-
-#include "configuration.moc"

src/commons/crashhandler.h

@@ -23,8 +23,8 @@
 
 class CrashHandler {
 public:
-  CrashHandler(const std::list<int> &install_signals);
-  CrashHandler(const std::initializer_list<int> &install_signals);
+  explicit CrashHandler(const std::list<int> &install_signals);
+  explicit CrashHandler(const std::initializer_list<int> &install_signals);
   ~CrashHandler();
 };
 

src/commons/exposuretimer.cpp

@@ -76,5 +76,3 @@ void ExposureTimer::Private::finished()
   timer->stop();
   emit q->finished();
 }
-
-#include "exposuretimer.moc"

src/commons/filesystembrowser.cpp

@@ -15,7 +15,4 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
  */
-
 #include "filesystembrowser.h"
-#include "filesystembrowser.moc"
-

src/commons/fps_counter.cpp

@@ -79,7 +79,3 @@ fps_counter& fps_counter::operator++()
     d->timeout();
   return *this;
 }
-
-
-
-#include "fps_counter.moc"

src/commons/messageslogger.cpp

@@ -45,6 +45,3 @@ MessagesLogger * MessagesLogger::instance()
   static MessagesLogger *instance = new MessagesLogger;
   return instance;
 }
-
-
-#include "messageslogger.moc"

src/commons/ser_header.cpp

@@ -58,10 +58,11 @@ int SER_Header::bytesPerPixel() const
 
 Frame::ColorFormat SER_Header::frame_color_format() const
 {
-  for(auto format: color_format_conversion()) {
-    if(format.second == static_cast<ColorId>(colorId))
-      return format.first;
-  }
+  auto formats = color_format_conversion();
+  auto format_it = find_if(begin(formats), end(formats), [this](auto format) {
+    return format.second == static_cast<ColorId>(this->colorId);
+  });
+  return format_it == end(formats) ? Frame::Mono : format_it->first;
 }
 
 void SER_Header::set_color_format(const Frame::ColorFormat& format)