keep absolute origins

Author: max-ostapenko

definitions/output/reports/tech_crux.js

@@ -294,40 +294,6 @@ lab_data AS (
     version
 ),
 
-audits AS (
-  SELECT
-    geo,
-    client,
-    rank,
-    technology,
-    version,
-    category,
-    id,
-    COUNT(DISTINCT root_page) AS origins
-  FROM (
-    SELECT DISTINCT
-      client,
-      page,
-      root_page,
-      audits.category,
-      audits.id
-    FROM pages
-    INNER JOIN UNNEST(get_passed_audits(pages.lighthouse)) AS audits
-  ) AS audits_data
-  INNER JOIN technologies
-  USING (client, page)
-  INNER JOIN crux
-  USING (client, root_page)
-  GROUP BY
-    geo,
-    client,
-    rank,
-    technology,
-    version,
-    category,
-    id
-),
-
 base_summary AS (
   SELECT
     geo,
@@ -387,14 +353,43 @@ audits_summary AS (
     technology,
     version,
     ARRAY_AGG(STRUCT(
-      category AS category,
-      id AS id,
-      audits.origins AS origins,
-      SAFE_DIVIDE(audits.origins, base_summary.origins) AS pass_rate
+      category,
+      id,
+      pass_origins
     )) AS audits
-  FROM audits
-  LEFT JOIN base_summary
-  USING (geo, client, rank, technology, version)
+  FROM (
+    SELECT
+      geo,
+      client,
+      rank,
+      technology,
+      version,
+      category,
+      id,
+      COUNT(DISTINCT root_page) AS pass_origins
+    FROM (
+      SELECT DISTINCT
+        client,
+        page,
+        root_page,
+        audits.category,
+        audits.id
+      FROM pages
+      INNER JOIN UNNEST(get_passed_audits(pages.lighthouse)) AS audits
+    ) AS audits_data
+    INNER JOIN technologies
+    USING (client, page)
+    INNER JOIN crux
+    USING (client, root_page)
+    GROUP BY
+      geo,
+      client,
+      rank,
+      technology,
+      version,
+      category,
+      id
+  )
   GROUP BY
     geo,
     client,

definitions/output/reports/tech_report_audits.js

@@ -16,18 +16,18 @@ CREATE TEMP FUNCTION GET_AUDITS(
     audits ARRAY<STRUCT<
       category STRING,
       id STRING,
-      pass_rate FLOAT64
+      pass_origins FLOAT64
     >>
   >>
 )
 RETURNS ARRAY<STRUCT<
   category STRING,
   id STRING,
   mobile STRUCT<
-    pass_rate FLOAT64
+    pass_origins FLOAT64
   >,
   desktop STRUCT<
-    pass_rate FLOAT64
+    pass_origins FLOAT64
   >
 >>
 LANGUAGE js AS '''
@@ -45,15 +45,15 @@ records.forEach(function(record) {
       auditMap[key] = {
         category: audit.category,
         id: audit.id,
-        mobile: { pass_rate: 0 },
-        desktop: { pass_rate: 0 }
+        mobile: { pass_origins: 0 },
+        desktop: { pass_origins: 0 }
       };
     }
-    // Add the pass_rate to the proper client type.
+    // Add the pass_origins to the proper client type.
     if (record.client === 'mobile') {
-      auditMap[key].mobile.pass_rate += audit.pass_rate;
+      auditMap[key].mobile.pass_origins += audit.pass_origins;
     } else if (record.client === 'desktop') {
-      auditMap[key].desktop.pass_rate += audit.pass_rate;
+      auditMap[key].desktop.pass_origins += audit.pass_origins;
     }
   });
 });