Skip to content

Commit 4c19008

Browse files
max-ostapenkoGCP Dataform
authored andcommitted
fix configs
1 parent 0fe4cc1 commit 4c19008

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

definitions/output/reports/report_cwv_by_shopify_theme.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,10 +191,10 @@ ORDER BY
191191
SELECT
192192
reports.run_export_job(
193193
JSON '''{
194-
"destination": "storage",
194+
"destination": "cloud_storage",
195195
"config": {
196196
"bucket": "${constants.bucket}",
197-
"name": "httparchive/reports/${pastMonth.replaceAll('-', '_')}/cruxShopifyThemes.json"
197+
"name": "${constants.storagePath}${pastMonth.replaceAll('-', '_')}/cruxShopifyThemes_test.json"
198198
},
199199
"query": "SELECT * FROM ${ctx.self()}"
200200
}'''

includes/constants.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ const [
2020
'AND rank <= 10000'
2121
]
2222
: ['', '']
23+
const bucket = 'httparchive'
24+
const storagePath = 'reports/'
2325

2426
class DataformTemplateBuilder {
2527
/**
@@ -72,5 +74,7 @@ module.exports = {
7274
environment,
7375
devTABLESAMPLE,
7476
devRankFilter,
75-
DataformTemplateBuilder
77+
DataformTemplateBuilder,
78+
bucket,
79+
storagePath
7680
}

0 commit comments

Comments
 (0)