report adjusted

Author: max-ostapenko

definitions/output/reports/tech_report_categories.js

@@ -8,9 +8,11 @@ publish('tech_report_categories', {
 WITH pages AS (
   SELECT DISTINCT
     client,
-    root_page,
-    technologies
-  FROM ${ctx.ref('crawl', 'pages')}
+    category,
+    root_page
+  FROM ${ctx.ref('crawl', 'pages')} AS pages
+  INNER JOIN pages.technologies AS tech
+  INNER JOIN tech.categories AS category
   WHERE
     date = '${pastMonth}'
     ${constants.devRankFilter}
@@ -36,7 +38,7 @@ crux AS (
 merged_pages AS (
   SELECT DISTINCT
     client,
-    technologies,
+    category,
     root_page
   FROM pages
   INNER JOIN crux
@@ -45,46 +47,40 @@ merged_pages AS (
 
 category_stats AS (
   SELECT
+    client,
     category,
-    STRUCT(
-      MAX(IF(client = 'desktop', origins, 0)) AS desktop,
-      MAX(IF(client = 'mobile', origins, 0)) AS mobile
-    ) AS origins
-  FROM (
-    SELECT
-      client,
-      category,
-      COUNT(DISTINCT root_page) AS origins
-    FROM merged_pages
-    INNER JOIN merged_pages.technologies AS tech
-    INNER JOIN tech.categories AS category
-    WHERE
-      category IS NOT NULL
-    GROUP BY
-      client,
-      category
-  )
-  GROUP BY category
+    COUNT(DISTINCT root_page) AS origins
+  FROM merged_pages
+  GROUP BY
+    client,
+    category
 ),
 
 technology_stats AS (
   SELECT
+    client,
     technology,
     category_obj AS categories,
-    origins.mobile AS mobile_origins
-  FROM ${ctx.ref('reports', 'tech_report_technologies')}
+    IF(client = 'mobile', origins.mobile, origins.desktop) AS origins
+  FROM ${ctx.ref('reports', 'tech_report_technologies')},
+    UNNEST(ARRAY['desktop', 'mobile']) AS client
 )
 
 SELECT
+  client,
   category,
   description,
   origins,
-  ARRAY_AGG(technology IGNORE NULLS ORDER BY technology_stats.mobile_origins DESC) AS technologies
+  IF(
+    client = 'mobile',
+    ARRAY_AGG(technology IGNORE NULLS ORDER BY technology_stats.origins.mobile DESC),
+    ARRAY_AGG(technology IGNORE NULLS ORDER BY technology_stats.origins.desktop DESC)
+  ) AS technologies
 FROM category_stats
 INNER JOIN technology_stats
 ON category_stats.category IN UNNEST(technology_stats.categories)
 INNER JOIN category_descriptions
-USING (category)
+USING (category, client)
 GROUP BY
   category,
   description,
@@ -93,20 +89,13 @@ GROUP BY
 UNION ALL
 
 SELECT
+  client,
   'ALL' AS category,
   NULL AS description,
-  STRUCT(
-    MAX(IF(client = 'desktop', origins, 0)) AS desktop,
-    MAX(IF(client = 'mobile', origins, 0)) AS mobile
-  ) AS origins,
+  COUNT(DISTINCT root_page) AS origins,
   NULL AS technologies
-FROM (
-  SELECT
-    client,
-    COUNT(DISTINCT root_page) AS origins
-  FROM merged_pages
-  GROUP BY client
-)
+FROM merged_pages
+GROUP BY client
 `).postOps(ctx => `
   SELECT
     reports.run_export_job(