Merge pull request #207 from HackMelbourne/fix/linting-problems

flatplum · web-flow · commit 3cfb1bdcb6e0 · 2025-09-15T22:38:08.000+10:00
Fix/linting problems
diff --git a/functions/index.js b/functions/index.js
@@ -239,4 +239,4 @@ exports.getLinksPage = onCall(
 //   await getFirestore().collection("riserData").add(result);
 
 //   return { text: "hi" };
-// });
+// });
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -46,6 +46,7 @@
     "@vitejs/plugin-react": "^3.1.0",
     "autoprefixer": "^10.4.16",
     "eslint": "^8.51.0",
+    "eslint-config-google": "^0.14.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-react": "^7.33.2",
diff --git a/src/components/Button/HMButton.tsx b/src/components/Button/HMButton.tsx
@@ -18,7 +18,7 @@ const HMButton = ({ text, color, style, span, link }: Props) => {
     style = 'disabled';
   }
 
-  let key = {
+  const key = {
     filled: {
       primary: ['bg-yellow-500'],
       secondary: ['bg-blue-500'],
diff --git a/src/routes/Events.tsx b/src/routes/Events.tsx
@@ -60,14 +60,14 @@ const Events = () => {
   // Animations
   const scrollRef = useRef(null);
 
-  let { scrollYProgress } = useScroll({
+  const { scrollYProgress } = useScroll({
     target: scrollRef,
     offset: ["start start", "end start"],
   });
 
-  let y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
-  let opacityValue = useTransform(scrollYProgress, [0, 0.8], ["100%", "0%"]);
-  let scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
+  const y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
+  const opacityValue = useTransform(scrollYProgress, [0, 0.8], ["100%", "0%"]);
+  const scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
 
   return (
     <div className="w-screen max-w-full">
diff --git a/src/routes/MeetTheTeam.tsx b/src/routes/MeetTheTeam.tsx
@@ -108,14 +108,14 @@ const MeetTheTeam = () => {
   // Animations
   const scrollRef = useRef(null);
 
-  let { scrollYProgress } = useScroll({
+  const { scrollYProgress } = useScroll({
     target: scrollRef,
     offset: ["start start", "end start"],
   });
 
-  let y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
-  let opacityValue = useTransform(scrollYProgress, [0, 0.7], ["100%", "0%"]);
-  let scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
+  const y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
+  const opacityValue = useTransform(scrollYProgress, [0, 0.7], ["100%", "0%"]);
+  const scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
 
   return (
     <div>
diff --git a/src/routes/Sponsors.tsx b/src/routes/Sponsors.tsx
@@ -96,14 +96,14 @@ const Sponsors = () => {
   // Animations
   const scrollRef = useRef(null);
 
-  let { scrollYProgress } = useScroll({
+  const { scrollYProgress } = useScroll({
     target: scrollRef,
     offset: ["start start", "end start"],
   });
 
-  let y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
-  let opacityValue = useTransform(scrollYProgress, [0, 0.7], ["100%", "0%"]);
-  let scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
+  const y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
+  const opacityValue = useTransform(scrollYProgress, [0, 0.7], ["100%", "0%"]);
+  const scaleValue = useTransform(scrollYProgress, [0, 0.8], ["1", "0.9"]);
 
   return (
     <div className="w-screen max-w-full">
diff --git a/src/routes/eventPages/GameComplete.tsx b/src/routes/eventPages/GameComplete.tsx
@@ -6,7 +6,7 @@ import { RiserOutputData } from "./RiserGame.model";
 import { useLocation, useNavigate } from "react-router-dom";
 
 const GameComplete = () => {
-  let data: RiserOutputData = useLocation().state;
+  const data: RiserOutputData = useLocation().state;
 
   const navigate = useNavigate();
 
diff --git a/src/routes/eventPages/OWeek.tsx b/src/routes/eventPages/OWeek.tsx
@@ -82,13 +82,13 @@ export default function RiserGame() {
 
   // Animations
   const scrollRef = useRef(null);
-  let { scrollYProgress } = useScroll({
+  const { scrollYProgress } = useScroll({
     target: scrollRef,
     offset: ["start start", "end start"],
   });
-  let y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
-  let opacityValue = useTransform(scrollYProgress, [0, 0.6], ["100%", "0%"]);
-  let scaleValue = useTransform(scrollYProgress, [0, 0.9], ["1", "0.9"]);
+  const y = useTransform(scrollYProgress, [0, 1], ["0%", "80%"]);
+  const opacityValue = useTransform(scrollYProgress, [0, 0.6], ["100%", "0%"]);
+  const scaleValue = useTransform(scrollYProgress, [0, 0.9], ["1", "0.9"]);
 
   // Form Field Values
   const [firstName, setFirstName] = useState("");
diff --git a/src/routes/eventPages/OWeekGame.tsx b/src/routes/eventPages/OWeekGame.tsx
@@ -7,7 +7,7 @@ import { RiserGameModel, RiserOutputData, RiserUserInput } from "./RiserGame.mod
 
 const OWeekGame = () => {
   const navigate = useNavigate();
-  let data: RiserUserInput = useLocation().state;
+  const data: RiserUserInput = useLocation().state;
 
   // If data is empty
   useEffect(() => {
@@ -23,7 +23,7 @@ const OWeekGame = () => {
 
   const [result, setResult] = useState<number[]>([]);
 
-  let userGameData: RiserGameModel = {
+  const userGameData: RiserGameModel = {
     name: data.name,
     email: data.email,
     studentID: data.studentID,
@@ -75,7 +75,7 @@ const OWeekGame = () => {
       alert("Oops! You went over 2024! Your score is disqualified");
       result.push(0);
     } else {
-      let tempResult = result;
+      const tempResult = result;
       tempResult.push(time);
       setResult(tempResult);
       console.log(result);
diff --git a/src/services/cleanEmails.ts b/src/services/cleanEmails.ts
@@ -1,9 +1,9 @@
 export default function cleanEmail(email: string): string {
   // Define the regex pattern
-  var pattern = /\.(?=.*@)|\+.*(?=@)/g;
+  const pattern = /\.(?=.*@)|\+.*(?=@)/g;
 
   // Use replace() method to replace matches with an empty string
-  var outputString = email.replace(pattern, "");
+  const outputString = email.replace(pattern, "");
 
   return outputString;
 }
diff --git a/src/services/firestoreServices.ts b/src/services/firestoreServices.ts
@@ -58,7 +58,7 @@ export async function isUniqueEmail(id: string): Promise<boolean> {
 export async function getRiserLeaderboard(): Promise<RankEntry[]> {
   const leaderboardRef = collection(db, "riserData");
 
-  let leaderboardData: RankEntry[] = [];
+  const leaderboardData: RankEntry[] = [];
 
   try {
     // Add orderby time when firebase functions implements feature
diff --git a/src/services/linksPageServices.ts b/src/services/linksPageServices.ts
@@ -5,7 +5,7 @@ import { LinkItemProps } from "../features/LinkItem/LinkItemProps";
 
 export async function getLinksPage(): Promise<LinkItemProps[]> {
   try {
-    let result = await httpsCallable(functions, "getLinksPage")();
+    const result = await httpsCallable(functions, "getLinksPage")();
 
     // Storing result to localStorage for faster load times for next visits
     localStorage.setItem("links", JSON.stringify(result));
diff --git a/src/services/meetTeamServices.ts b/src/services/meetTeamServices.ts
@@ -5,7 +5,7 @@ import { Member } from "../features/TeamComponent/TeamComponent.model";
 
 export async function getMeetTheTeam(): Promise<Member[]> {
   try {
-    let result = await httpsCallable(functions, "getMeetTheTeam")();
+    const result = await httpsCallable(functions, "getMeetTheTeam")();
     return result.data as Member[];
   } catch (e) {
     console.log(e);
diff --git a/src/services/tournamentServices.ts b/src/services/tournamentServices.ts
@@ -5,7 +5,7 @@ import { TournamentBracketProps } from "../features/TournamentBracket/Tournament
 
 export async function getHackiethonBrackets(): Promise<TournamentBracketProps[]> {
   try {
-    let result = await httpsCallable(functions, "getHackiethonBrackets")();
+    const result = await httpsCallable(functions, "getHackiethonBrackets")();
     return result.data as TournamentBracketProps[];
   } catch (e) {
     console.log(e);

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ const HMButton = ({ text, color, style, span, link }: Props) => {`
`18`	`18`	`style = 'disabled';`
`19`	`19`	`}`
`20`	`20`
`21`		`- let key = {`
	`21`	`+ const key = {`
`22`	`22`	`filled: {`
`23`	`23`	`primary: ['bg-yellow-500'],`
`24`	`24`	`secondary: ['bg-blue-500'],`