add assertions for all dii_types in unit tests

Author: swibi-ttd

src/test/java/com/uid2/operator/UIDOperatorVerticleTest.java

@@ -2905,6 +2905,15 @@ void identityMapBatchRequestTooLargeForPhone(Vertx vertx, VertxTestContext testC
         send(vertx, "v2/identity/map", req, 413, json -> testContext.completeNow());
     }
 
+    private double getIdentityMapInputAmount(String path, String diiType) {
+        DistributionSummary ds = registry
+                .find("uid2_operator_identity_map_inputs")
+                .tag("path", path)
+                .tag("dii_type", diiType)
+                .summary();
+        return ds == null ? 0.0 : ds.totalAmount();
+    }
+
     @Test
     void identityMapV2InputMetricTaggedWithEmailDiiType(Vertx vertx, VertxTestContext testContext) {
         fakeAuth(201, Role.MAPPER);
@@ -2915,13 +2924,10 @@ void identityMapV2InputMetricTaggedWithEmailDiiType(Vertx vertx, VertxTestContex
                 .put("email", new JsonArray().add("test1@uid2.com").add("test2@uid2.com"));
 
         send(vertx, "v2/identity/map", req, 200, json -> {
-            DistributionSummary summary = Metrics.globalRegistry
-                    .get("uid2_operator_identity_map_inputs")
-                    .tag("path", "/v2/identity/map")
-                    .tag("dii_type", "email")
-                    .summary();
-            assertNotNull(summary);
-            assertEquals(2.0, summary.totalAmount());
+            assertEquals(2.0, getIdentityMapInputAmount("/v2/identity/map", "email"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "email_hash"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "phone"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "phone_hash"));
             testContext.completeNow();
         });
     }
@@ -2937,13 +2943,10 @@ void identityMapV2InputMetricTaggedWithEmailHashDiiType(Vertx vertx, VertxTestCo
                         .add(TokenUtils.getIdentityHashString("test1@uid2.com")));
 
         send(vertx, "v2/identity/map", req, 200, json -> {
-            DistributionSummary summary = Metrics.globalRegistry
-                    .get("uid2_operator_identity_map_inputs")
-                    .tag("path", "/v2/identity/map")
-                    .tag("dii_type", "email_hash")
-                    .summary();
-            assertNotNull(summary);
-            assertEquals(1.0, summary.totalAmount());
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "email"));
+            assertEquals(1.0, getIdentityMapInputAmount("/v2/identity/map", "email_hash"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "phone"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v2/identity/map", "phone_hash"));
             testContext.completeNow();
         });
     }
@@ -2960,22 +2963,10 @@ void identityMapV3InputMetricTaggedWithPathAndDiiType(Vertx vertx, VertxTestCont
                         .add(TokenUtils.getIdentityHashString("+15555555555")));
 
         send(vertx, "v3/identity/map", req, 200, json -> {
-            DistributionSummary emailSummary = Metrics.globalRegistry
-                    .get("uid2_operator_identity_map_inputs")
-                    .tag("path", "/v3/identity/map")
-                    .tag("dii_type", "email")
-                    .summary();
-            assertNotNull(emailSummary);
-            assertEquals(2.0, emailSummary.totalAmount());
-
-            DistributionSummary phoneHashSummary = Metrics.globalRegistry
-                    .get("uid2_operator_identity_map_inputs")
-                    .tag("path", "/v3/identity/map")
-                    .tag("dii_type", "phone_hash")
-                    .summary();
-            assertNotNull(phoneHashSummary);
-            assertEquals(1.0, phoneHashSummary.totalAmount());
-
+            assertEquals(2.0, getIdentityMapInputAmount("/v3/identity/map", "email"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v3/identity/map", "email_hash"));
+            assertEquals(0.0, getIdentityMapInputAmount("/v3/identity/map", "phone"));
+            assertEquals(1.0, getIdentityMapInputAmount("/v3/identity/map", "phone_hash"));
             testContext.completeNow();
         });
     }