Skip to content

Commit df3d96c

Browse files
committed
update statsCollectorVerticle
1 parent 6292ae3 commit df3d96c

2 files changed

Lines changed: 6 additions & 30 deletions

File tree

src/main/java/com/uid2/operator/monitoring/StatsCollectorVerticle.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,14 @@ public void handleMessage(Message message) {
8989
}
9090

9191
String path = messageItem.getPath();
92-
String apiVersion = "v0";
93-
String endpoint = path.substring(1);
92+
String apiVersion = "unknown";
93+
String endpoint = path.startsWith("/") ? path.substring(1) : path;
9494

95-
if(path.length() > 1 && path.charAt(1) == 'v') {
95+
if (path.length() > 1 && path.charAt(1) == 'v') {
9696
int apiVIndex = path.indexOf("/", 1);
9797
if (apiVIndex > 1) {
98-
apiVersion = path.substring(1, apiVIndex);
98+
apiVersion = path.substring(1, apiVIndex); // e.g., "v2", "v3", "v4"
9999
endpoint = path.substring(apiVIndex + 1);
100-
} else {
101-
apiVersion = "unknown";
102100
}
103101
}
104102

src/test/java/com/uid2/operator/StatsCollectorVerticleTest.java

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -73,28 +73,6 @@ private void triggerSerializeAndWait(VertxTestContext testContext) throws JsonPr
7373
testContext.awaitCompletion(LOG_WAIT_INTERVAL, TimeUnit.MILLISECONDS);
7474
}
7575

76-
@Test
77-
void testJSONSerializeWithV0AndV1Paths(Vertx vertx, VertxTestContext testContext) throws InterruptedException, JsonProcessingException {
78-
StatsCollectorMessageItem messageItem = new StatsCollectorMessageItem("/test", "https://test.com", "test", 1, CLIENT_VERSION);
79-
sendStatMessage(messageItem);
80-
sendStatMessage(messageItem);
81-
sendStatMessage(messageItem);
82-
83-
messageItem = new StatsCollectorMessageItem("/v1/test", "https://test.com", "test", 1, CLIENT_VERSION);
84-
sendStatMessage(messageItem);
85-
sendStatMessage(messageItem);
86-
waitForLogInterval(testContext);
87-
88-
triggerSerializeAndWait(testContext);
89-
90-
var expectedList = List.of("{\"endpoint\":\"test\",\"siteId\":1,\"apiVersion\":\"v1\",\"domainList\":[{\"domain\":\"test.com\",\"count\":2,\"apiContact\":\"test\"}]}",
91-
"{\"endpoint\":\"test\",\"siteId\":1,\"apiVersion\":\"v0\",\"domainList\":[{\"domain\":\"test.com\",\"count\":3,\"apiContact\":\"test\"}]}");
92-
var messages = getMessages();
93-
assertThat(messages).containsAll(expectedList);
94-
95-
testContext.completeNow();
96-
}
97-
9876
private static void waitForLogInterval(VertxTestContext testContext) throws InterruptedException {
9977
testContext.awaitCompletion(JSON_INTERVAL*2, TimeUnit.MILLISECONDS);
10078
}
@@ -160,11 +138,11 @@ void invalidPathsLimit(Vertx vertx, VertxTestContext testContext) throws Interru
160138
var messages = getMessages();
161139
// MAX_INVALID_PATHS is not the hard limit. The maximum paths that can be recorded, including valid ones, is MAX_INVALID_PATHS + validPaths.size * 2
162140
for(int i = 0; i < MAX_INVALID_PATHS + Endpoints.pathSet().size(); i++) {
163-
String expected = "{\"endpoint\":\"bad" + i + "\",\"siteId\":1,\"apiVersion\":\"v0\",\"domainList\":[{\"domain\":\"test.com\",\"count\":1,\"apiContact\":\"test\"}]}";
141+
String expected = "{\"endpoint\":\"bad" + i + "\",\"siteId\":1,\"apiVersion\":\"unknown\",\"domainList\":[{\"domain\":\"test.com\",\"count\":1,\"apiContact\":\"test\"}]}";
164142
assertThat(messages).contains(expected);
165143
}
166144
for(int i = MAX_INVALID_PATHS + Endpoints.pathSet().size(); i < MAX_INVALID_PATHS + 5; i++) {
167-
String expected = "{\"endpoint\":\"bad" + i + "\",\"siteId\":1,\"apiVersion\":\"v0\",\"domainList\":[{\"domain\":\"test.com\",\"count\":1,\"apiContact\":\"test\"}]}";
145+
String expected = "{\"endpoint\":\"bad" + i + "\",\"siteId\":1,\"apiVersion\":\"unknown\",\"domainList\":[{\"domain\":\"test.com\",\"count\":1,\"apiContact\":\"test\"}]}";
168146
assertThat(messages).contains(expected);
169147
}
170148
assertThat(getMessages()).contains("max invalid paths reached; a large number of invalid paths have been requested from authenticated participants");

0 commit comments

Comments
 (0)