Skip to content

Commit 5ee6b8f

Browse files
author
Yoshito Umaoka
committed
Use Java package mapping for both JAVA and JAVAUTF8
1 parent 278b79d commit 5ee6b8f

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

gp-ant-task/src/main/java/com/ibm/g11n/pipeline/ant/GPBaseTask.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import com.ibm.g11n.pipeline.client.ServiceAccount;
4141
import com.ibm.g11n.pipeline.client.ServiceClient;
4242
import com.ibm.g11n.pipeline.client.ServiceException;
43+
import com.ibm.g11n.pipeline.resfilter.impl.DefaultResourceFilterProvider;
4344

4445
/**
4546
* Base class of GP download/upload ant tasks
@@ -240,7 +241,7 @@ private String pathToBundleId(String type, String path) {
240241
parent.getPath().replace(File.separatorChar, '.');
241242

242243
String fileName = f.getName().replaceAll(" ", "_");
243-
if (type.equals("JAVA")) {
244+
if (DefaultResourceFilterProvider.isJavaType(type)) {
244245
int dotIdx = fileName.indexOf('.');
245246
if (dotIdx >= 0) {
246247
fileName = fileName.substring(0, dotIdx);

gp-maven-plugin/src/main/java/com/ibm/g11n/pipeline/maven/GPBaseMojo.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import com.ibm.g11n.pipeline.client.ServiceAccount;
3939
import com.ibm.g11n.pipeline.client.ServiceClient;
4040
import com.ibm.g11n.pipeline.client.ServiceException;
41+
import com.ibm.g11n.pipeline.resfilter.impl.DefaultResourceFilterProvider;
4142

4243
/**
4344
* Base class of GP download/upload Mojo.
@@ -207,7 +208,7 @@ private String pathToBundleId(String type, String path) {
207208
parent.getPath().replace(File.separatorChar, '.');
208209

209210
String fileName = f.getName().replaceAll(" ", "_");
210-
if (type.equals("JAVA")) {
211+
if (DefaultResourceFilterProvider.isJavaType(type)) {
211212
int dotIdx = fileName.indexOf('.');
212213
if (dotIdx >= 0) {
213214
fileName = fileName.substring(0, dotIdx);

gp-res-filter/src/main/java/com/ibm/g11n/pipeline/resfilter/impl/DefaultResourceFilterProvider.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,12 @@ public MultiBundleResourceFilter getMultiBundleResourceFilter(String id) {
124124
return null;
125125
}
126126

127+
// TODO: GP Maven/Ant plugin uses different path-bundle name mapping for Java.
128+
// This method is used for checking if the type is one of Java types.
129+
// We probably should provide path-bundle name mapping "function" as a part
130+
// of ResourceFilter/MultiBundleResourceFilter interface instead. Revisit this later.
131+
public static boolean isJavaType(String type) {
132+
type = type.toUpperCase(Locale.ROOT);
133+
return type.equals(Filter.JAVA.name()) || type.equals(Filter.JAVAUTF8.name());
134+
}
127135
}

0 commit comments

Comments
 (0)