Skip to content

Commit 787c1d8

Browse files
authored
Merge pull request #112 from srl295/silence-json-test
Silence json test
2 parents 929d4c4 + 73de316 commit 787c1d8

3 files changed

Lines changed: 1 addition & 12 deletions

File tree

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ before_install:
1616
- echo -n | openssl s_client -connect scan.coverity.com:443 | sed -ne '/-BEGIN CERTIFICATE-/,/-END CERTIFICATE-/p' | sudo tee -a /etc/ssl/certs/ca-
1717

1818
after_success:
19-
- mvn clean cobertura:cobertura org.eluder.coveralls:coveralls-maven-plugin:report
19+
- mvn clean cobertura:cobertura org.eluder.coveralls:coveralls-maven-plugin:report -Dcobertura.report.format=xml
2020

2121
addons:
2222
coverity_scan:

gp-res-filter/src/test/java/com/ibm/g11n/pipeline/resfilter/impl/JsonResourceTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -166,12 +166,6 @@ public void testWrite() throws IOException, ResourceFilterException {
166166
}
167167
}
168168

169-
// @Test
170-
// public void testTestFiles() throws IOException, ResourceFilterException {
171-
// // just test the test files
172-
// ResourceTestUtil.compareFilesJson(INPUT_FILE, EXPECTED_WRITE_FILE);
173-
// }
174-
175169
@Test
176170
public void testReWrite() throws IOException, ResourceFilterException {
177171
// First parse
@@ -208,18 +202,14 @@ public void testReWriteOther() throws IOException, ResourceFilterException {
208202
LanguageBundle bundle = res2.parse(is, null);
209203
List<ResourceString> resStrList = new ArrayList<>(bundle.getResourceStrings());
210204
Collections.sort(resStrList, new ResourceStringComparator());
211-
// assertEquals("ResourceStrings did not match.",
212-
// EXPECTED_INPUT_RES_LIST, resStrList);
213205

214206
// Now write
215207
File tempFile = File.createTempFile(this.getClass().getSimpleName(), "3.json");
216-
// File tempFile = new File("/tmp/3.json");
217208
tempFile.deleteOnExit();
218209

219210
try (OutputStream os = new FileOutputStream(tempFile)) {
220211
res.write(os, bundle, null);
221212
os.flush();
222-
System.out.println(ResourceTestUtil.fileToString(tempFile));
223213
ResourceTestUtil.compareFilesJson(INPUT_FILE2, tempFile);
224214
}
225215
}

pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
<artifactId>cobertura-maven-plugin</artifactId>
104104
<version>2.7</version>
105105
<configuration>
106-
<format>xml</format>
107106
<maxmem>256m</maxmem>
108107
<!-- aggregated reports for multi-module projects -->
109108
<aggregate>true</aggregate>

0 commit comments

Comments
 (0)