code efficiency improvements

Author: ArdenButterfield

panel.js

@@ -226,10 +226,9 @@ class Panel {
     for (let i = 1; i <= num_ticks; ++i) {
       let tick_amp_pixels = i * pixel_max / num_ticks / this.settings.ampZoom;
       // let tick_amp_db = linToDB(tick_amp_pixels, pixel_max);
-      this.drawHorizontalTick((tick_amp_pixels/pixel_max).toFixed(2), this.halfh - tick_amp_pixels*this.settings.ampZoom,5,"right");
-      this.drawHorizontalTick((-tick_amp_pixels/pixel_max).toFixed(2), this.halfh + tick_amp_pixels*this.settings.ampZoom,5,"right");
-      // this.drawHorizontalTick(tick_amp_db.toFixed(1) + 'dBFS', this.halfh - tick_amp_pixels*this.settings.ampZoom,5, "right");
-      // this.drawHorizontalTick(tick_amp_db.toFixed(1) + 'dBFS', this.halfh + tick_amp_pixels*this.settings.ampZoom,5, "right");
+      // TODO: bring these back once I figure out why they are so inefficient
+      // this.drawHorizontalTick((tick_amp_pixels/pixel_max).toFixed(2), this.halfh - tick_amp_pixels*this.settings.ampZoom,5,"right");
+      // this.drawHorizontalTick((-tick_amp_pixels/pixel_max).toFixed(2), this.halfh + tick_amp_pixels*this.settings.ampZoom,5,"right");
     }
     // this.drawHorizontalTick('-inf dBFS', this.halfh, 5, "right");
     this.drawHorizontalTick('0.00', this.halfh, 5, "right");

slider.js

@@ -14,7 +14,9 @@ class Slider {
   onEdit() {
     this.updateValue();
     this.settings.render();
-    // this.settings.p5.draw();
+    for (const pObj of this.settings.panelProcessingObjects) {
+      pObj.redraw();
+    }
   }
 
   resize(x, y, w, p) {

widget.js

@@ -71,6 +71,7 @@ function getDefaultSettings() {
     , render: undefined
     , play: playWave
     , renderStages : []
+    , panelProcessingObjects : []
   };
 
   settings.render = renderWavesImpl(settings, fft);
@@ -126,13 +127,15 @@ function createWidgets() {
     if (id in panelIdLookups) {
       const sketch = p => {
         p.panelObject = new panelIdLookups[id]();
+        settings.panelProcessingObjects.push(p);
         p.setup = function () {
           let canvas = p.createCanvas(450, 300);
           p.textAlign(p.CENTER);
           canvas.parent(id)
           p.panelObject.setup(p, 450, 300, settings);
           p.windowResized();
-          // p.noLoop();
+          p.noLoop();
+          p.redraw();
         };
         p.draw = function () {
           p.panelObject.drawPanel();
@@ -162,6 +165,7 @@ function createWidgets() {
           p.sliderObject.setup(p, settings);
           p.sliderObject.resize(0,0,500,50);
           p.sliderObject.onEdit();
+          p.redraw();
         }
       }
       new p5(sketch, id);