Harrison L3 - KJON/LFAR - CoDICE Lo: Updated direct events to use apd_energy from L2 when calculating the mass_per_charge, updated coefficients in the mass_coefficient_lookup.

Author: Menlo Innovations - CAVA Project

imap_l3_processing/codice/l3/lo/codice_lo_l3a_direct_events_dependencies.py

@@ -58,14 +58,14 @@ def fetch_dependencies(cls, dependencies: ProcessingInputCollection):
         direct_events_downloaded_path = download(direct_events_path)
 
         mass_coefficients_file_downloaded_path = download(mass_coefficients_file_path.name)
-        energy_per_charge_lookup_donwloaded_path = download(energy_per_charge_file_path.name)
+        energy_per_charge_lookup_downloaded_path = download(energy_per_charge_file_path.name)
 
         return cls.from_file_paths(
             sw_priority_rates_downloaded_path,
             nsw_priority_rates_downloaded_path,
             direct_events_downloaded_path,
             mass_coefficients_file_downloaded_path,
-            energy_per_charge_lookup_donwloaded_path
+            energy_per_charge_lookup_downloaded_path
         )
 
     @classmethod

imap_l3_processing/codice/l3/lo/codice_lo_processor.py

@@ -191,7 +191,7 @@ def process_l3a_direct_event_data_product(self, dependencies: CodiceLoL3aDirectE
                                  esa_energy_per_charge_lookup.num_bins, spin_angle_lut.num_bins), np.nan)
 
         try:
-            mass_per_charge = calculate_mass_per_charge(codice_direct_events.energy_step, codice_direct_events.tof)
+            mass_per_charge = calculate_mass_per_charge(codice_direct_events.apd_energy, codice_direct_events.tof)
             mass = calculate_mass(codice_direct_events.apd_energy, codice_direct_events.tof, mass_coefficient_lookup)
 
             spin_angle = (codice_direct_events.spin_angle + CODICE_SPIN_ANGLE_OFFSET_FROM_MAG_BOOM) % 360

tests/codice/l3/lo/science/test_codice_lo_calculations.py

@@ -75,7 +75,7 @@ def test_calculate_mass(self):
 
     def test_calculate_mass_per_charge(self):
         tof = np.array([[5], [6]])
-        energy_step = np.array([[1], [2]])
+        apd_energy = np.array([[1], [2]])
 
         POST_ACCELERATION_VOLTAGE_IN_KV = 15
         ENERGY_LOST_IN_CARBON_FOIL = 0
@@ -87,14 +87,14 @@ def test_calculate_mass_per_charge(self):
         mass_per_charge_2 = (2 + POST_ACCELERATION_VOLTAGE_IN_KV - ENERGY_LOST_IN_CARBON_FOIL) * (
                 6 ** 2) * CONVERSION_CONSTANT_K
 
-        actual_mass_per_charge = calculate_mass_per_charge(energy_step, tof)
+        actual_mass_per_charge = calculate_mass_per_charge(apd_energy, tof)
         np.testing.assert_array_equal(actual_mass_per_charge, np.array([[mass_per_charge_1], [mass_per_charge_2]]))
 
     def test_calculate_mass_per_charge_handles_fill_value(self):
         tof = np.ma.masked_array([[432, 234], [434, 347]], mask=[[False, True], [True, False]])
-        energy_step = np.array([[np.nan, 2342.2], [4324.8, np.nan]])
+        apd_energy = np.array([[np.nan, 2342.2], [4324.8, np.nan]])
 
-        actual_mass_per_charge = calculate_mass_per_charge(energy_step, tof)
+        actual_mass_per_charge = calculate_mass_per_charge(apd_energy, tof)
 
         self.assertIsInstance(actual_mass_per_charge, np.ma.masked_array)
         actual_filled_with_nan = np.ma.filled(actual_mass_per_charge, np.nan)

tests/codice/l3/lo/test_codice_lo_processor.py

@@ -522,7 +522,7 @@ def test_process_l3a_direct_events(self, mock_calculate_mass, mock_calculate_mas
         np.testing.assert_equal(mock_calculate_mass.call_args.args[2], dependencies.mass_coefficient_lookup)
 
         self.assertEqual(1, mock_calculate_mass_per_charge.call_count)
-        np.testing.assert_equal(mock_calculate_mass_per_charge.call_args.args[0], expected_energy_step)
+        np.testing.assert_equal(mock_calculate_mass_per_charge.call_args.args[0], expected_apd_energy)
         np.testing.assert_equal(mock_calculate_mass_per_charge.call_args.args[1], expected_tof)
 
         expected_spin_angles = (codice_l2_variables['spin_angle'] + 316) % 360

tests/integration/test_codice_processor_integration.py

@@ -20,7 +20,7 @@ class CodiceProcessorIntegration(unittest.TestCase):
     @patch("imap_l3_data_processor._parse_cli_arguments")
     def test_codice_processor_integration(self, mock_parse_cli_arguments):
         energy_per_charge_path = get_test_data_path('codice/imap_codice_lo-energy-per-charge_20241110_v001.csv')
-        mass_coefficient_path = get_test_data_path('codice/imap_codice_mass-coefficient-lookup_20241110_v002.csv')
+        mass_coefficient_path = get_test_data_path('codice/imap_codice_mass-coefficient-lookup_20241110_v003.csv')
         input_files = [
             self.TEST_DATA_DIR / 'imap_codice_l2_lo-direct-events_20250814_v001.cdf',
             self.TEST_DATA_DIR / 'imap_codice_l1a_lo-nsw-priority_20250814_v001.cdf',
@@ -64,7 +64,7 @@ def test_codice_processor_integration(self, mock_parse_cli_arguments):
                                 'imap_codice_l1a_lo-nsw-priority_20250814_v001.cdf',
                                 'imap_codice_l1a_lo-sw-priority_20250814_v001.cdf',
                                 'imap_codice_lo-energy-per-charge_20241110_v001.csv',
-                                'imap_codice_mass-coefficient-lookup_20241110_v002.csv'}
+                                'imap_codice_mass-coefficient-lookup_20241110_v003.csv'}
 
             with CDF(str(expected_map_path)) as cdf:
                 self.assertEqual(expected_parents, set(cdf.attrs["Parents"]))

tests/periodically_run_tests.json

@@ -1,7 +1,7 @@
 {
     "test_l3bcde_first_time_processing": "2026-01-12T15:52:36.971070",
     "test_spectral_fit_against_validation_data": "2026-01-13T13:11:14.411186",
-    "test_calculate_pickup_ions_with_minimize": "2026-01-12T15:32:27.729881",
+    "test_calculate_pickup_ions_with_minimize": "2026-01-19T15:33:51.973761",
     "test_ultra_all_sp_maps": "2026-01-19T13:12:39.624757",
     "test_ultra_combined_maps": null,
     "test_ultra_combined_nsp_maps": "2026-01-13T12:56:50.237322",

tests/test_data/codice/imap_codice_mass-coefficient-lookup_20241110_v003.csv

@@ -0,0 +1 @@
+-0.85674-0.363739-1.366120.303470.02904190.0557362