Skip to content

Commit 8c9c8c1

Browse files
committed
Quality fixes
1 parent 5e20bad commit 8c9c8c1

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

xmlvalidator-email/src/main/java/eu/europa/ec/itb/xml/email/MailHandler.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,11 +189,15 @@ public void receiveEmail() {
189189
} catch (ValidatorException e) {
190190
// Send error response to sender.
191191
messageAdditionalText.append("Failed to process message: %s%n".formatted(e.getMessageForDisplay(new LocalisationHelper(Locale.ENGLISH))));
192-
e.printStackTrace(new PrintWriter(new StringBuilderWriter(messageAdditionalText)));
192+
try (var out = new PrintWriter(new StringBuilderWriter(messageAdditionalText))) {
193+
e.printStackTrace(out);
194+
}
193195
} catch (Exception e) {
194196
// Send error response to sender.
195197
messageAdditionalText.append("Failed to process message: %s%n".formatted(e.getMessage()));
196-
e.printStackTrace(new PrintWriter(new StringBuilderWriter(messageAdditionalText)));
198+
try (var out = new PrintWriter(new StringBuilderWriter(messageAdditionalText))) {
199+
e.printStackTrace(out);
200+
}
197201
} finally {
198202
logger.info("Sending email response");
199203
try {

xmlvalidator-ws/src/main/java/eu/europa/ec/itb/xml/rest/model/ContextFileInfo.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ public void setEmbeddingMethod(String embeddingMethod) {
6363
* @return The rule set information.
6464
*/
6565
public FileContent toFileContent() {
66-
FileContent content = new FileContent();
67-
content.setContent(getContent());
68-
content.setEmbeddingMethod(FileContent.embeddingMethodFromString(getEmbeddingMethod()));
69-
return content;
66+
FileContent fileContent = new FileContent();
67+
fileContent.setContent(getContent());
68+
fileContent.setEmbeddingMethod(FileContent.embeddingMethodFromString(getEmbeddingMethod()));
69+
return fileContent;
7070
}
7171

7272
}

0 commit comments

Comments
 (0)