Check for 0 instance name

Author: aothms

parser/errors.py

@@ -105,4 +105,30 @@ def __str__(self):
         return (
             f"Invalid number of parameters for HEADER field '{self.field}'. "
             f"Expected {self.expected_len}, found {self.found_len}."
-        )
+        )
+
+
+class InvalidNameError(_ValidationError):
+    def __init__(self, filecontent, name, linenumbers):
+        self.name = name
+        self.filecontent = filecontent
+        self.linenumbers = linenumbers
+
+    def asdict(self, with_message=True):
+        return {
+            "type": "invalid_name",
+            "name": self.name,
+            "lineno": self.linenumbers[0],
+            "line": self.filecontent.split("\n")[self.linenumbers[0] - 1],
+            **({"message": str(self)} if with_message else {}),
+        }
+
+    def __str__(self):
+        d = self.asdict(with_message=False)
+
+        def build():
+            yield f"On line {d['lineno']}:\nInvalid instance name #{d['name']}"
+            yield f"{d['lineno']:05d} | {d['line']}"
+            yield " " * 8 + "^" * len(d["line"].rstrip())
+
+        return "\n".join(build())

parser/parse.py

@@ -43,13 +43,18 @@ def process_tree(filecontent, file_tree, with_progress, error_collector):
             sys.stdout.flush()
         ent = create_step_entity(entity_tree)
         id_ = int(ent["id"])
+        if id_ == 0:
+            error_collector.add(InvalidNameError(filecontent, ent["id"], ent["lines"]))
         if ents[id_]:
-            error_collector.add(DuplicateNameError(filecontent, ent["id"], ent["lines"]))
+            error_collector.add(
+                DuplicateNameError(filecontent, ent["id"], ent["lines"])
+            )
         else:
             ents[id_].append(ent)
 
     return header, ents
 
+
 def parse(
     *,
     filename=None,
@@ -148,19 +153,22 @@ def replace_fn(match):
 
     if with_tree:
         header, data = process_tree(filecontent, ast, with_progress, error_collector)
-        error_collector.raise_if_any() 
-        return ParseResult(
-            header = header, 
-            entities = data
-        )
+        error_collector.raise_if_any()
+        return ParseResult(header=header, entities=data)
     else:
         # process_tree() would take care of duplicate identifiers,
         # but we need to do it ourselves now using our rudimentary
         # transformer
         seen = set()
         for iden, lineno in instance_identifiers:
+            if iden == 0:
+                error_collector.add(
+                    InvalidNameError(filecontent, iden, [lineno, lineno])
+                )
             if iden in seen:
-                error_collector.add(DuplicateNameError(filecontent, iden, [lineno, lineno]))
+                error_collector.add(
+                    DuplicateNameError(filecontent, iden, [lineno, lineno])
+                )
             else:
                 seen.add(iden)
         error_collector.raise_if_any()