Skip to content

feat(*): adding jQuery deploy #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChronosSF wants to merge 2 commits into
base: vkombov/migrate-jquery-docs
Choose a base branch
from
Open

feat(*): adding jQuery deploy #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e193054
feat(*): adding jQuery deploy, deploy to igniteui.com, better path ma…
ChronosSF Apr 28, 2026
4d582ed
feat(*): adding unique jQuery ci to allow for paths-ignore
ChronosSF Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/_cd-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: _CD Deploy (reusable)
on:
workflow_call:
inputs:
platform:
description: 'Platform to build (angular, react, wc, blazor, jquery)'
required: true
type: string
locale:
description: 'Locale to build (en or jp)'
required: true
Expand All @@ -26,43 +30,39 @@ jobs:
name: Build and Deploy
runs-on: ubuntu-latest

strategy:
matrix:
platform: ['angular', 'react', 'wc', 'blazor']

steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
ref: ${{ inputs.target_ref }}
clean: true
fetch-tags: true
fetch-depth: 0

- name: Setup Node.js 22.x
uses: actions/setup-node@v4
- name: Setup Node.js 24.x
uses: actions/setup-node@v6
with:
Comment on lines +35 to 44
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout@v6 / actions/setup-node@v6 are inconsistent with the rest of the repo (CI uses @v4 for both in .github/workflows/ci.yml:20-25). If this isn’t an intentional upgrade across all workflows, consider keeping these aligned to reduce maintenance and unexpected behavior differences between CI and CD.

Copilot uses AI. Check for mistakes.
node-version: '22.x'
node-version: '24.x'

Comment on lines +42 to 46
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow pins Node.js to 24.x, but the repo’s CI uses Node 22 (see .github/workflows/ci.yml:22-25) and package.json declares engines.node >=22.12.0. To avoid deploy-only failures or differing build output vs CI, consider using the same Node major as CI (or update CI/engines in the same PR to match).

Copilot uses AI. Check for mistakes.
- name: Install dependencies
run: npm ci

- name: Build Documentation for ${{ matrix.platform }} (${{ inputs.locale }})
run: npm run build:${{ env.BUILD_TYPE }}:${{ matrix.platform }}:${{ inputs.locale }}
- name: Build Documentation for ${{ inputs.platform }} (${{ inputs.locale }})
run: npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build command here expects root-level scripts named build:<BUILD_TYPE>:<platform>:<locale>, but the repo only defines jQuery scripts as jquery:build-* (e.g. jquery:build-staging:en in package.json). With platform: jquery passed by the jQuery workflows, this step will fail because build:staging:jquery:en/jp is not defined. Consider either adding matching build:staging:jquery:* scripts at the root, or branching in the workflow to call the existing jquery:build-* scripts when inputs.platform == 'jquery'.

Suggested change
run: npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
run: |
if [ "${{ inputs.platform }}" = "jquery" ]; then
npm run jquery:build-${{ env.BUILD_TYPE }}:${{ inputs.locale }}
else
npm run build:${{ env.BUILD_TYPE }}:${{ inputs.platform }}:${{ inputs.locale }}
fi

Copilot uses AI. Check for mistakes.

- name: Package build
run: |
LOCALE="${{ inputs.locale }}"
DIST_DIR="dist/${{ matrix.platform }}$([[ "$LOCALE" == 'en' ]] && echo '' || echo "-$LOCALE")"
DIST_DIR="dist/${{ inputs.platform }}$([[ "$LOCALE" == 'en' ]] && echo '' || echo "-$LOCALE")"
cd "$DIST_DIR"
zip -r ../../${{ env.BUILD_TYPE }}_${{ matrix.platform }}_${{ inputs.locale }}.zip .
zip -r ../../${{ env.BUILD_TYPE }}_${{ inputs.platform }}_${{ inputs.locale }}.zip .
cd ../..

- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: igniteui-docs-${{ matrix.platform }}-${{ inputs.locale }}
path: ${{ env.BUILD_TYPE }}_${{ matrix.platform }}_${{ inputs.locale }}.zip
name: igniteui-docs-${{ inputs.platform }}-${{ inputs.locale }}
path: ${{ env.BUILD_TYPE }}_${{ inputs.platform }}_${{ inputs.locale }}.zip
retention-days: 1

- name: Trigger Deploy Workflow in IgniteUI Actions
Expand All @@ -77,11 +77,12 @@ jobs:
client_payload: {
calling_branch: "${{ inputs.target_ref }}",
environment: "${{ env.BUILD_TYPE }}",
artifact_name: "igniteui-docs-${{ matrix.platform }}-${{ inputs.locale }}",
base_href: "docs-${{ matrix.platform }}-new",
platform: "${{ matrix.platform }}",
artifact_name: "igniteui-docs-${{ inputs.platform }}-${{ inputs.locale }}",
base_href: "docs-${{ inputs.platform }}-new",
platform: "${{ inputs.platform }}",
repository: "${{ github.repository }}",
run_id: "${{ github.run_id }}",
locale: "${{ inputs.locale }}"
locale: "${{ inputs.locale }}",
deploy_igniteui: ${{ inputs.platform == 'jquery' }}
}
});
34 changes: 34 additions & 0 deletions .github/workflows/cd-angular-en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Build And Deploy Angular Documentation EN

permissions:
contents: read

on:
push:
branches:
- vnext
- master
paths-ignore:
- 'docs/jquery/**'
- 'docs/xplat/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/jp/**'
- '**/kr/**'
workflow_dispatch:
inputs:
branch:
description: 'Branch to checkout'
type: string
default: 'vnext'

jobs:
deploy:
uses: ./.github/workflows/_cd-deploy.yml
with:
locale: en
platform: angular
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
34 changes: 34 additions & 0 deletions .github/workflows/cd-angular-jp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Build And Deploy Angular Documentation JP

permissions:
contents: read

on:
push:
branches:
- vnext
- master
paths-ignore:
- 'docs/jquery/**'
- 'docs/xplat/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/en/**'
- '**/kr/**'
workflow_dispatch:
inputs:
branch:
description: 'Branch to checkout'
type: string
default: 'vnext'

jobs:
deploy:
uses: ./.github/workflows/_cd-deploy.yml
with:
locale: jp
platform: angular
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
8 changes: 7 additions & 1 deletion .github/workflows/cd-en.yml → .github/workflows/cd-jquery-en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build And Deploy Documentation EN
name: Build And Deploy jQuery Documentation EN

permissions:
contents: read
Expand All @@ -9,6 +9,11 @@ on:
- vnext
- master
paths-ignore:
- 'docs/angular/**'
- 'docs/xplat/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/jp/**'
- '**/kr/**'
workflow_dispatch:
Expand All @@ -23,6 +28,7 @@ jobs:
uses: ./.github/workflows/_cd-deploy.yml
with:
locale: en
platform: jquery
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
8 changes: 7 additions & 1 deletion .github/workflows/cd-jp.yml → .github/workflows/cd-jquery-jp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build And Deploy Documentation JP
name: Build And Deploy jQuery Documentation JP

permissions:
contents: read
Expand All @@ -9,6 +9,11 @@ on:
- vnext
- master
paths-ignore:
- 'docs/angular/**'
- 'docs/xplat/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/en/**'
- '**/kr/**'
workflow_dispatch:
Expand All @@ -23,6 +28,7 @@ jobs:
uses: ./.github/workflows/_cd-deploy.yml
with:
locale: jp
platform: jquery
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
38 changes: 38 additions & 0 deletions .github/workflows/cd-xplat-en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Build And Deploy XPlat Documentation EN

permissions:
contents: read

on:
push:
branches:
- vnext
- master
paths-ignore:
- 'docs/jquery/**'
- 'docs/angular/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/jp/**'
- '**/kr/**'
workflow_dispatch:
inputs:
branch:
description: 'Branch to checkout'
type: string
default: 'vnext'

jobs:
deploy:
strategy:
matrix:
platform: ['react', 'wc', 'blazor']

uses: ./.github/workflows/_cd-deploy.yml
with:
locale: en
platform: ${{ matrix.platform }}
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
38 changes: 38 additions & 0 deletions .github/workflows/cd-xplat-jp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Build And Deploy XPlat Documentation JP

permissions:
contents: read

on:
push:
branches:
- vnext
- master
paths-ignore:
- 'docs/jquery/**'
- 'docs/angular/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'
- '**/en/**'
- '**/kr/**'
workflow_dispatch:
inputs:
branch:
description: 'Branch to checkout'
type: string
default: 'vnext'

jobs:
deploy:
strategy:
matrix:
platform: ['react', 'wc', 'blazor']

uses: ./.github/workflows/_cd-deploy.yml
with:
locale: jp
platform: ${{ matrix.platform }}
target_ref: ${{ github.event.inputs.branch && (startsWith(github.event.inputs.branch, 'refs/') && github.event.inputs.branch || format('refs/heads/{0}', github.event.inputs.branch)) || github.ref }}
secrets:
CLASSIC_PAT_GITHUB: ${{ secrets.CLASSIC_PAT_GITHUB }}
34 changes: 34 additions & 0 deletions .github/workflows/ci-jquery.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: CI jQuery
permissions:
contents: read

on:
pull_request:
branches: [ master, vnext ]
paths-ignore:
- 'docs/angular/**'
- 'docs/xplat/**'
- 'docs/wpf/**'
- 'docs/winforms/**'
- 'docs/aspnet/**'

jobs:
build-and-verify:

runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v6

- name: Use Node.js 24.x
uses: actions/setup-node@v6
with:
node-version: 24
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Build jQuery
run: npm run jquery:build
4 changes: 2 additions & 2 deletions docs/jquery/astro.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ if (docsEnv !== 'development' && docsEnv !== 'staging' && docsEnv !== 'productio
const mode: DocsMode = docsEnv;

// ── Site URL — varies by build mode ─────────────────────────────────────────
const PROD_HOST = 'https://www.infragistics.com';
const STAGING_HOST = 'https://staging.infragistics.com';
const PROD_HOST = 'https://www.igniteui.com';
const STAGING_HOST = 'https://staging.igniteui.com';

// jp.infragistics.com is the JP domain; the base path is the same as en.
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment about jp.infragistics.com being the JP domain is now out of date since this config switched to igniteui.com hosts. Updating/removing it would avoid confusion for future maintainers (especially since jQuery JP content uses the ja/ folder while DOCS_LANG is jp).

Suggested change
// jp.infragistics.com is the JP domain; the base path is the same as en.
// JP builds use the 'jQueryJP' platform entry to resolve the correct base path;
// production/staging hosts are shared igniteui.com domains for all languages.

Copilot uses AI. Check for mistakes.
const platformKey = docsLang === 'jp' ? 'jQueryJP' : 'jQuery';
Expand Down
4 changes: 2 additions & 2 deletions src/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,13 @@ export const IGDOCS_PLATFORMS: Record<string, PlatformMeta> = {
},
jQuery: {
lang: 'en', label: 'jQuery', key: 'jquery', devPort: 4335,
base: '/docs-jquery',
base: '/docs-jquery-new',
title: 'Ignite UI for jQuery',
description: 'Component documentation for Ignite UI for jQuery.',
},
jQueryJP: {
lang: 'jp', label: 'jQuery', key: 'jquery', devPort: 4345,
base: '/docs-jquery',
base: '/docs-jquery-new',
title: 'Ignite UI for jQuery',
description: 'Component documentation for Ignite UI for jQuery.',
},
Expand Down