Repository navigation
Commit ce1000f
rebase: surface assertions an infra-failed run already reported (#172)
## The miss this fixes
During the v0.30.0 campaign the run summary read:
```
tests: 30 passed, 1 failed (1 infra), 3 skipped
✗ push_gate: precommit red; phase-3 infrastructure failure: simple_diffusion_test: timeout
```
That reads as "clean apart from an infrastructure nuisance". It wasn't.
`simple_diffusion_test` had reported **10 quantization assertion
failures** and was *then* killed. Because the infra branch recorded only
the label and moved on, those ids were discarded with the log.
The push gate blocked on that signal and was **right** — but its message
named only a timeout, which made a correct block look like flakiness
worth overriding. The 10 failures stayed invisible until Buildkite #3055
re-found them, as two distinct upstream contract changes
(vllm-project/vllm-omni#7820).
## Change
`test_loop` still classifies timeout / watchdog kill / harness crash as
**structural** (Rev 8 §2.3): out of `failed_tests`, no baseline split,
no debug agent, push gate blocks. **That is unchanged** — the existing
`test_test_loop_infra_is_structural` is untouched and passes, which is
the guard.
What changes is that the infra record now names what the run *did* find:
```
killed: timeout — 2 assertion failure(s) reported before the structural end:
tests/…::TestA::test_one, tests/…::TestB::test_two
```
Reuses `ci_loop.extract_failed_test_ids` rather than adding a second
parser.
## One thing worth reviewing closely
`TestRunResult.output` carries **either log text or a path to the log
file** — the production caller (`engine/steps/rebase_v3._to_result`)
passes `outcome.log_file`. My first version parsed the pathname and
would have been **inert in production**; my own tests missed it because
they supplied inline text. The staged-diff review gate caught it.
`_log_text()` now reads the file when `output` is one, and degrades to
"no ids found" on a read error so a filesystem problem can never change
the classification.
## Tests
Four new cases: assertions surfaced from inline text; from a **log
path** (the production shape); an unreadable log stays structural; an
infra-only failure keeps the terse record.
Full suite green; `check_spec_freshness --strict` 0 stale.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 4e1b701 commit ce1000f
3 files changed
Lines changed: 157 additions & 2 deletions
File tree
- doc/architecture/SPEC
- src/infermatrix_copilot/rebase_engine
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
32 | 57 | | |
33 | 58 | | |
34 | 59 | | |
| |||
141 | 166 | | |
142 | 167 | | |
143 | 168 | | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
144 | 187 | | |
145 | 188 | | |
146 | | - | |
| 189 | + | |
147 | 190 | | |
148 | 191 | | |
149 | 192 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
263 | 263 | | |
264 | 264 | | |
265 | 265 | | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
266 | 368 | | |
267 | 369 | | |
268 | 370 | | |
| |||
0 commit comments