From 94fc53931b874f4c59c6b93348bb13a18f89df78 Mon Sep 17 00:00:00 2001 From: "Hans J. Johnson" Date: Thu, 2 Jul 2026 13:39:48 -0500 Subject: [PATCH] COMP: Pin DCMTK with single-export namespace fix DCMTK's GenerateCMakeExports.cmake wrote DCMTKTargets.cmake with three export(APPEND) calls; CMake's append mode skips the cross-export-set namespace lookup and blindly prefixes DCMTK:: onto ITK's codec targets, recording the nonexistent DCMTK::ITK::ITKZLIBModule (and TIFF/JPEG/PNG). An external consumer of an ITK build tree then fails at generate. The pinned InsightSoftwareConsortium/DCMTK#3 merges the exports into a single export() call so foreign targets resolve to their ITK:: names. Root cause analysis and DCMTK fix by Bradley Lowekamp. --- Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake b/Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake index d6166ae391d..cd8d94d9850 100644 --- a/Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake +++ b/Modules/ThirdParty/DCMTK/DCMTKGitTag.cmake @@ -38,7 +38,9 @@ set( #COMP: fix WASI compiler errors #COMP: fix missing header issue -#Bradley Lowekamp (1): +#Bradley Lowekamp (3): #COMP: prefix CMake check commands with DCMTK_ to avoid leaking +#COMP: Add printf format attribute to OFFile printf wrappers +#COMP: Use single export() call to fix namespace corruption -set(DCMTK_GIT_TAG "4ac9b4489d8f8fb1873a943dd214824bd2b11a6d") # for/itk-dcmtk-3.7.0-ccfd10b +set(DCMTK_GIT_TAG "554b74475ba1734655c61988b94bc69daf6690c7") # for/itk-dcmtk-3.7.0-ccfd10b