From 9be924cb5992e72c2997e0192d464ef529ea24f9 Mon Sep 17 00:00:00 2001 From: Hans Johnson Date: Fri, 3 Apr 2026 15:27:17 -0500 Subject: [PATCH 1/2] COMP: Update CI to ITKRemoteModuleBuildTestPackageAction v5.4.6 and Python 3.10+ - Bump reusable workflow from v5.4.0 to v5.4.6 (fixes macos-13 deprecation, adds GHCR dockcross pre-pull with retry) - Update minimum Python version to 3.10+ - Use secrets: inherit to simplify secret passing and avoid YAML errors from empty secrets: blocks Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/build-test-package.yml | 9 +++++---- pyproject.toml | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-test-package.yml b/.github/workflows/build-test-package.yml index 1bae10b..c56ab3d 100644 --- a/.github/workflows/build-test-package.yml +++ b/.github/workflows/build-test-package.yml @@ -1,14 +1,15 @@ - name: Build, test, package on: [push,pull_request] jobs: cxx-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.0 + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-cxx.yml@v5.4.6 python-build-workflow: - uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.0 + uses: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction/.github/workflows/build-test-package-python.yml@v5.4.6 with: + itk-wheel-tag: 'v5.4.5' + itk-python-package-tag: 'v5.4.5' test-notebooks: false - secrets: + secrets: inherit diff --git a/pyproject.toml b/pyproject.toml index a94f617..828e81e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -34,7 +34,7 @@ classifiers = [ "Topic :: Scientific/Engineering :: Medical Science Apps.", "Topic :: Software Development :: Libraries", ] -requires-python = ">=3.8" +requires-python = ">=3.10" dependencies = [ "itk-core == 5.4.*", ] From c4994667b47fd290d84573b12b63595f6f969e00 Mon Sep 17 00:00:00 2001 From: "Hans J. Johnson" Date: Sun, 12 Apr 2026 21:13:23 -0500 Subject: [PATCH 2/2] BUG: Fix Vector-to-Point implicit conversion in CartesianToPolarTransform In recent ITK versions, the implicit conversion from itk::Vector to itk::Point was removed. Point::operator-(Point) returns a VectorType, not a PointType, so the local variable must be declared as InputVectorType rather than InputPointType. itkCartesianToPolarTransform.hxx:53 - const InputPointType vector = inputPoint - this->m_Center; + const InputVectorType vector = inputPoint - this->m_Center; Co-Authored-By: Claude Opus 4.6 (1M context) --- include/itkCartesianToPolarTransform.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/itkCartesianToPolarTransform.hxx b/include/itkCartesianToPolarTransform.hxx index 951d006..80de827 100644 --- a/include/itkCartesianToPolarTransform.hxx +++ b/include/itkCartesianToPolarTransform.hxx @@ -50,7 +50,7 @@ CartesianToPolarTransform::TransformPoint(con { OutputPointType outputPoint(inputPoint); - const InputPointType vector = inputPoint - this->m_Center; + const InputVectorType vector = inputPoint - this->m_Center; outputPoint[1] = std::sqrt(vector[0] * vector[0] + vector[1] * vector[1]); // r= sqrt(x^2 + y^2) outputPoint[0] = std::acos(vector[0] / outputPoint[1]); // alpha = acos(x/r)