Skip to content

Commit a28065e

Browse files
committed
address PR comments
1 parent 3a9ce96 commit a28065e

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

dpctl/_sycl_queue.pxd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ cdef public api class _SyclQueue [
4343
cdef DPCTLSyclQueueRef _queue_ref
4444
cdef SyclContext _context
4545
cdef SyclDevice _device
46-
cdef object __weakref__
4746

4847

4948
cdef public api class SyclQueue (_SyclQueue) [

dpctl/apis/include/dpctl4pybind11.hpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,9 @@ class dpctl_capi
141141

142142
static std::mutex init_mtx;
143143

144-
// release gil while holding lock
144+
// initialization requires calls into Python C-API, so initializing
145+
// thread must hold the GIL, while other threads must not block on the
146+
// mutex while holding the GIL, as this creates a deadlock
145147
py::gil_scoped_release release;
146148
std::lock_guard<std::mutex> lock(init_mtx);
147149

dpctl/utils/src/sequential_order_keeper.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class SequentialOrder
186186

187187
void wait()
188188
{
189-
// snapeshot events outside of mutex to avoid
189+
// snapshot events outside of mutex to avoid
190190
// calling wait inside mutex
191191
std::vector<sycl::event> sub_copy;
192192
std::vector<sycl::event> ht_copy;

0 commit comments

Comments
 (0)