Skip to content

Commit b857f0c

Browse files
committed
rename more names
1 parent 8149575 commit b857f0c

1 file changed

Lines changed: 27 additions & 25 deletions

File tree

src/main/java/de/srendi/advancedperipherals/common/util/inventory/InventoryUtil.java

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,15 @@ public static IItemHandler extractHandler(@Nullable Object object) {
4545
}
4646

4747
public static int moveItem(IItemHandler inventoryFrom, IItemHandler inventoryTo, ItemFilter filter) {
48-
if (inventoryFrom == null) return 0;
48+
if (inventoryFrom == null) {
49+
return 0;
50+
}
4951

5052
final int fromSlot = filter.getFromSlot();
5153
final int toSlot = filter.getToSlot();
5254

5355
final int required = filter.getCount();
54-
int transferableAmount = 0;
56+
int transferred = 0;
5557

5658
// The logic changes with storage systems since these systems do not have slots
5759
if (inventoryFrom instanceof IStorageSystemItemHandler storageSystemHandler) {
@@ -61,7 +63,7 @@ public static int moveItem(IItemHandler inventoryFrom, IItemHandler inventoryTo,
6163
return storageSystemHandler.extractItem(filter, extracted.getCount() - remains.getCount(), false).getCount();
6264
}
6365
for (int i = toSlot == -1 ? 0 : toSlot; i < (toSlot == -1 ? inventoryTo.getSlots() : toSlot + 1); i++) {
64-
ItemStack extracted = storageSystemHandler.extractItem(filter, required - transferableAmount, true);
66+
ItemStack extracted = storageSystemHandler.extractItem(filter, required - transferred, true);
6567
if (extracted.isEmpty()) {
6668
break;
6769
}
@@ -71,18 +73,18 @@ public static int moveItem(IItemHandler inventoryFrom, IItemHandler inventoryTo,
7173
} else {
7274
remains = inventoryTo.insertItem(toSlot, extracted, false);
7375
}
74-
transferableAmount += storageSystemHandler.extractItem(filter, extracted.getCount() - remains.getCount(), false).getCount();
75-
if (transferableAmount >= filter.getCount()) {
76+
transferred += storageSystemHandler.extractItem(filter, extracted.getCount() - remains.getCount(), false).getCount();
77+
if (transferred >= filter.getCount()) {
7678
break;
7779
}
7880
}
79-
return transferableAmount;
81+
return transferred;
8082
}
8183

8284
if (inventoryTo instanceof IStorageSystemItemHandler storageSystemHandler) {
8385
for (int i = fromSlot == -1 ? 0 : fromSlot; i < (fromSlot == -1 ? inventoryFrom.getSlots() : fromSlot + 1); i++) {
8486
if (filter.test(inventoryFrom.getStackInSlot(i))) {
85-
ItemStack extracted = inventoryFrom.extractItem(i, required - transferableAmount, true);
87+
ItemStack extracted = inventoryFrom.extractItem(i, required - transferred, true);
8688
if (extracted.isEmpty()) {
8789
continue;
8890
}
@@ -91,18 +93,18 @@ public static int moveItem(IItemHandler inventoryFrom, IItemHandler inventoryTo,
9193
if (inserted == 0) {
9294
break;
9395
}
94-
transferableAmount += inventoryFrom.extractItem(i, inserted, false).getCount();
95-
if (transferableAmount >= filter.getCount()) {
96+
transferred += inventoryFrom.extractItem(i, inserted, false).getCount();
97+
if (transferred >= filter.getCount()) {
9698
break;
9799
}
98100
}
99101
}
100-
return transferableAmount;
102+
return transferred;
101103
}
102104

103105
for (int i = fromSlot == -1 ? 0 : fromSlot; i < (fromSlot == -1 ? inventoryFrom.getSlots() : fromSlot + 1); i++) {
104106
if (filter.test(inventoryFrom.getStackInSlot(i))) {
105-
ItemStack extracted = inventoryFrom.extractItem(i, required - transferableAmount, true);
107+
ItemStack extracted = inventoryFrom.extractItem(i, required - transferred, true);
106108
if (extracted.isEmpty()) {
107109
continue;
108110
}
@@ -116,48 +118,48 @@ public static int moveItem(IItemHandler inventoryFrom, IItemHandler inventoryTo,
116118
if (inserted == 0) {
117119
break;
118120
}
119-
transferableAmount += inventoryFrom.extractItem(i, inserted, false).getCount();
120-
if (transferableAmount >= filter.getCount()) {
121+
transferred += inventoryFrom.extractItem(i, inserted, false).getCount();
122+
if (transferred >= filter.getCount()) {
121123
break;
122124
}
123125
}
124126
}
125-
return transferableAmount;
127+
return transferred;
126128
}
127129

128130
public static int moveFluid(IFluidHandler inventoryFrom, IFluidHandler inventoryTo, FluidFilter filter) {
129-
if (inventoryFrom == null) return 0;
131+
if (inventoryFrom == null) {
132+
return 0;
133+
}
130134

131-
int amount = filter.getCount();
132-
int transferableAmount = 0;
135+
final int required = filter.getCount();
136+
int transferred = 0;
133137

134138
// The logic changes with storage systems since these systems do not have slots
135139
if (inventoryFrom instanceof IStorageSystemFluidHandler storageSystemHandler) {
136140
FluidStack extracted = storageSystemHandler.drain(filter, IFluidHandler.FluidAction.SIMULATE);
137141
int inserted = inventoryTo.fill(extracted, IFluidHandler.FluidAction.EXECUTE);
138142

139-
transferableAmount += storageSystemHandler.drain(filter.setCount(inserted), IFluidHandler.FluidAction.EXECUTE).getAmount();
143+
transferred += storageSystemHandler.drain(filter.setCount(inserted), IFluidHandler.FluidAction.EXECUTE).getAmount();
140144

141-
return transferableAmount;
145+
return transferred;
142146
}
143147

144148
if (inventoryTo instanceof IStorageSystemFluidHandler storageSystemHandler) {
145149
if (filter.test(inventoryFrom.getFluidInTank(0))) {
146150
FluidStack toExtract = inventoryFrom.getFluidInTank(0).copy();
147-
toExtract.setAmount(amount);
151+
toExtract.setAmount(required);
148152
FluidStack extracted = inventoryFrom.drain(toExtract, IFluidHandler.FluidAction.SIMULATE);
149153
if (extracted.isEmpty())
150154
return 0;
151155
int inserted = storageSystemHandler.fill(extracted, IFluidHandler.FluidAction.EXECUTE);
152156

153157
extracted.setAmount(inserted);
154-
transferableAmount += inventoryFrom.drain(extracted, IFluidHandler.FluidAction.EXECUTE).getAmount();
158+
transferred += inventoryFrom.drain(extracted, IFluidHandler.FluidAction.EXECUTE).getAmount();
155159
}
156-
157-
return transferableAmount;
160+
return transferred;
158161
}
159-
160-
return transferableAmount;
162+
return transferred;
161163
}
162164

163165

0 commit comments

Comments
 (0)